Added a test file for shared_code_in_if_blocks

Author: xFrednet

tests/ui/shared_code_in_if_blocks.rs

@@ -0,0 +1,174 @@
+#![allow(dead_code)]
+#![warn(clippy::if_same_then_else)]
+
+macro_rules! foo {
+    () => {
+        println!("I'm a macro, yay");
+    };
+}
+
+
+macro_rules! bar {
+    () => {
+        println!("I'm a macro, yay");
+    };
+}
+
+/// This should be caught by the `if_same_then_else` lint and be ignored by the 
+/// `shared_code_in_if_blocks` lint
+fn other_lint() {
+    let x = 10;
+    if x == 0 {
+        // I'm the real start of arrays
+        println!("Hello World");
+    } else {
+        // I'm an awesome number
+        // Hello @reviewer
+        println!("Hello World");
+    }
+
+    let _me = if x == 9 {
+        42
+    } else {
+        42
+    };
+
+    let _duck = if x == 8 {
+        7
+    } else if x == 5 {
+        7
+    } else {
+        7
+    };
+
+    // Only two blocks are the same
+    let _ = if x == 9 {
+        9
+    } else if x == 7 {
+        7
+    } else {
+        7
+    };
+}
+
+fn everything_is_okay() {
+    let x = 10;
+    // This is currently a false positive
+    if x == 0 {
+        foo!();
+    } else {
+        bar!();
+    }
+
+    // Single branch
+    if x == 1 {
+        println!("I'm an awesome clippy test")
+    }
+
+    // Same start in two blocks
+    if x == 10 {
+        println!("x is a value");
+        println!("x is 10");
+    } else if x == 1 {
+        println!("x is 1");
+    } else {
+        println!("x is a value");
+    }
+
+    // Shared code in the middle
+    let _ = if x == 7 {
+        let z = 3;
+        println!("x is a value");
+        z
+    } else if x == 100 {
+        let y = 1;
+        println!("x is a value");
+        y
+    } else {
+        let x = 2;
+        println!("x is a value");
+        x
+    };
+
+    // Different macros and just a return should be simple
+    let _z = if x == 8 {
+        println!("Branch 1");
+        let z = 10;
+        foo!();
+        z
+    } else {
+        println!("Branch 2");
+        let z = 10;
+        bar!();
+        z
+    };
+}
+
+
+fn shared_code_at_start() {
+    let x = 17;
+    
+    // First statement is the same
+    let _ = if x == 1 {
+        // I'm a comment that shouldn't matter for the lint
+        println!("Hello World");
+
+        4
+    } else {
+        // I'm another comment,
+        // Nice to see you here in the tests
+        println!("Hello World");
+        
+        16
+    };
+
+    // First statement is the same
+    if x == 19 {
+        println!("Hello World");
+        let mut y = 9;
+        y += 1;
+        let _z = y;
+    } else {
+        println!("Hello World");
+    };
+    
+    if x == 8 {
+        println!("Hello World");
+        let _ = true;
+    } else if x != 2 {
+        println!("Hello World");
+        let _ = false;
+    } else {
+        println!("Hello World");
+    }
+}
+
+fn shared_code_at_end() {
+    let x = 10;
+
+    // Same code at the end
+    if x == 8 {
+        let _ = true;
+        println!("Hello World");
+    } else if x != 2 {
+        let _ = false;
+        println!("Hello World");
+    } else {
+        println!("Hello World");
+    }
+
+    let _z = if x == 8 {
+        println!("Branch 1");
+        let z = 10;
+        bar!();
+        z
+    } else {
+        println!("Branch 2");
+        let z = 10;
+        bar!();
+        z
+    };
+}
+
+fn main () {}
+