Skip to content

Commit 1e15bbe

Browse files
committed
Pass real crate-level attributes to pre_expansion_lint
1 parent 551220c commit 1e15bbe

File tree

3 files changed

+29
-6
lines changed

3 files changed

+29
-6
lines changed

Diff for: compiler/rustc_interface/src/passes.rs

+6-2
Original file line numberDiff line numberDiff line change
@@ -240,13 +240,15 @@ fn pre_expansion_lint(
240240
sess: &Session,
241241
lint_store: &LintStore,
242242
krate: &ast::Crate,
243+
crate_attrs: &[ast::Attribute],
243244
crate_name: &str,
244245
) {
245246
sess.prof.generic_activity_with_arg("pre_AST_expansion_lint_checks", crate_name).run(|| {
246247
rustc_lint::check_ast_crate(
247248
sess,
248249
lint_store,
249250
&krate,
251+
crate_attrs,
250252
true,
251253
None,
252254
rustc_lint::BuiltinCombinedPreExpansionLintPass::new(),
@@ -266,7 +268,7 @@ pub fn configure_and_expand(
266268
resolver: &mut Resolver<'_>,
267269
) -> Result<ast::Crate> {
268270
tracing::trace!("configure_and_expand");
269-
pre_expansion_lint(sess, lint_store, &krate, crate_name);
271+
pre_expansion_lint(sess, lint_store, &krate, &krate.attrs, crate_name);
270272
rustc_builtin_macros::register_builtin_macros(resolver);
271273

272274
krate = sess.time("crate_injection", || {
@@ -323,9 +325,10 @@ pub fn configure_and_expand(
323325
..rustc_expand::expand::ExpansionConfig::default(crate_name.to_string())
324326
};
325327

328+
let crate_attrs = krate.attrs.clone();
326329
let extern_mod_loaded = |ident: Ident, attrs, items, span| {
327330
let krate = ast::Crate { attrs, items, span };
328-
pre_expansion_lint(sess, lint_store, &krate, &ident.name.as_str());
331+
pre_expansion_lint(sess, lint_store, &krate, &crate_attrs, &ident.name.as_str());
329332
(krate.attrs, krate.items)
330333
};
331334
let mut ecx = ExtCtxt::new(&sess, cfg, resolver, Some(&extern_mod_loaded));
@@ -469,6 +472,7 @@ pub fn lower_to_hir<'res, 'tcx>(
469472
sess,
470473
lint_store,
471474
&krate,
475+
&krate.attrs,
472476
false,
473477
Some(std::mem::take(resolver.lint_buffer())),
474478
rustc_lint::BuiltinCombinedEarlyLintPass::new(),

Diff for: compiler/rustc_lint/src/context.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -805,14 +805,15 @@ impl<'a> EarlyContext<'a> {
805805
sess: &'a Session,
806806
lint_store: &'a LintStore,
807807
krate: &'a ast::Crate,
808+
crate_attrs: &'a [ast::Attribute],
808809
buffered: LintBuffer,
809810
warn_about_weird_lints: bool,
810811
) -> EarlyContext<'a> {
811812
EarlyContext {
812813
sess,
813814
krate,
814815
lint_store,
815-
builder: LintLevelsBuilder::new(sess, warn_about_weird_lints, lint_store, &krate.attrs),
816+
builder: LintLevelsBuilder::new(sess, warn_about_weird_lints, lint_store, crate_attrs),
816817
buffered,
817818
}
818819
}

Diff for: compiler/rustc_lint/src/early.rs

+21-3
Original file line numberDiff line numberDiff line change
@@ -329,12 +329,20 @@ fn early_lint_crate<T: EarlyLintPass>(
329329
sess: &Session,
330330
lint_store: &LintStore,
331331
krate: &ast::Crate,
332+
crate_attrs: &[ast::Attribute],
332333
pass: T,
333334
buffered: LintBuffer,
334335
warn_about_weird_lints: bool,
335336
) -> LintBuffer {
336337
let mut cx = EarlyContextAndPass {
337-
context: EarlyContext::new(sess, lint_store, krate, buffered, warn_about_weird_lints),
338+
context: EarlyContext::new(
339+
sess,
340+
lint_store,
341+
krate,
342+
crate_attrs,
343+
buffered,
344+
warn_about_weird_lints,
345+
),
338346
pass,
339347
};
340348

@@ -355,6 +363,7 @@ pub fn check_ast_crate<T: EarlyLintPass>(
355363
sess: &Session,
356364
lint_store: &LintStore,
357365
krate: &ast::Crate,
366+
crate_attrs: &[ast::Attribute],
358367
pre_expansion: bool,
359368
lint_buffer: Option<LintBuffer>,
360369
builtin_lints: T,
@@ -365,14 +374,22 @@ pub fn check_ast_crate<T: EarlyLintPass>(
365374
let mut buffered = lint_buffer.unwrap_or_default();
366375

367376
if !sess.opts.debugging_opts.no_interleave_lints {
368-
buffered =
369-
early_lint_crate(sess, lint_store, krate, builtin_lints, buffered, pre_expansion);
377+
buffered = early_lint_crate(
378+
sess,
379+
lint_store,
380+
krate,
381+
crate_attrs,
382+
builtin_lints,
383+
buffered,
384+
pre_expansion,
385+
);
370386

371387
if !passes.is_empty() {
372388
buffered = early_lint_crate(
373389
sess,
374390
lint_store,
375391
krate,
392+
crate_attrs,
376393
EarlyLintPassObjects { lints: &mut passes[..] },
377394
buffered,
378395
false,
@@ -386,6 +403,7 @@ pub fn check_ast_crate<T: EarlyLintPass>(
386403
sess,
387404
lint_store,
388405
krate,
406+
crate_attrs,
389407
EarlyLintPassObjects { lints: slice::from_mut(pass) },
390408
buffered,
391409
pre_expansion && i == 0,

0 commit comments

Comments
 (0)