ImproperCTypes: rename associated tests

Rustc is trying to shift away from test names that are just issue
numbers, so we add this as part of its effort, since this commit chain
is moving and rewriting these files anyway.
The directory containing all tests is also renamed.

Author: niacdoial

tests/ui/lint/improper_ctypes/allow_improper_ctypes.rs renamed to tests/ui/lint/improper-ctypes/allow-improper-ctypes.rs

@@ -1,5 +1,5 @@
 error: `extern` callback uses type `(i32, i32)`, which is not FFI-safe
-  --> $DIR/allow_improper_ctypes.rs:39:20
+  --> $DIR/allow-improper-ctypes.rs:39:20
    |
 LL | type UnsafeFnPtr = extern "C" fn((i32, i32))->i32;
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -8,42 +8,42 @@ LL | type UnsafeFnPtr = extern "C" fn((i32, i32))->i32;
    = help: consider using a struct instead
    = note: tuples have unspecified layout
 note: the lint level is defined here
-  --> $DIR/allow_improper_ctypes.rs:2:9
+  --> $DIR/allow-improper-ctypes.rs:2:9
    |
 LL | #![deny(improper_c_callbacks)]
    |         ^^^^^^^^^^^^^^^^^^^^
 
 error: `extern` fn uses type `&str`, which is not FFI-safe
-  --> $DIR/allow_improper_ctypes.rs:75:35
+  --> $DIR/allow-improper-ctypes.rs:75:35
    |
 LL | extern "C" fn fn1u(e: &String) -> &str {&*e}
    |                                   ^^^^ not FFI-safe
    |
    = help: consider using `*const u8` and a length instead
    = note: this reference to an unsized type contains metadata, which makes it incompatible with a C pointer
 note: the lint level is defined here
-  --> $DIR/allow_improper_ctypes.rs:1:26
+  --> $DIR/allow-improper-ctypes.rs:1:26
    |
 LL | #![deny(improper_ctypes, improper_c_fn_definitions)]
    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^
 
 error: `extern` fn uses type `UnsafeStruct`, which is not FFI-safe
-  --> $DIR/allow_improper_ctypes.rs:81:23
+  --> $DIR/allow-improper-ctypes.rs:81:23
    |
 LL | extern "C" fn fn2u(e: UnsafeStruct) {}
    |                       ^^^^^^^^^^^^ not FFI-safe
    |
    = note: this struct/enum/union (`UnsafeStruct`) is FFI-unsafe due to a `String` field
 note: the type is defined here
-  --> $DIR/allow_improper_ctypes.rs:18:1
+  --> $DIR/allow-improper-ctypes.rs:18:1
    |
 LL | struct UnsafeStruct (String);
    | ^^^^^^^^^^^^^^^^^^^
    = help: consider adding a `#[repr(C)]` (not `#[repr(C,packed)]`) or `#[repr(transparent)]` attribute to `String`
    = note: `String` has unspecified layout
 
 error: `extern` fn uses type `ext_crate::UnsafeStruct`, which is not FFI-safe
-  --> $DIR/allow_improper_ctypes.rs:85:24
+  --> $DIR/allow-improper-ctypes.rs:85:24
    |
 LL | extern "C" fn fn2ou(e: ext_crate::UnsafeStruct) {}
    |                        ^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -53,22 +53,22 @@ LL | extern "C" fn fn2ou(e: ext_crate::UnsafeStruct) {}
    = note: `String` has unspecified layout
 
 error: `extern` fn uses type `AllowedUnsafeStruct`, which is not FFI-safe
-  --> $DIR/allow_improper_ctypes.rs:90:23
+  --> $DIR/allow-improper-ctypes.rs:90:23
    |
 LL | extern "C" fn fn3u(e: AllowedUnsafeStruct) {}
    |                       ^^^^^^^^^^^^^^^^^^^ not FFI-safe
    |
    = note: this struct/enum/union (`AllowedUnsafeStruct`) is FFI-unsafe due to a `String` field
 note: the type is defined here
-  --> $DIR/allow_improper_ctypes.rs:22:1
+  --> $DIR/allow-improper-ctypes.rs:22:1
    |
 LL | struct AllowedUnsafeStruct (String);
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^
    = help: consider adding a `#[repr(C)]` (not `#[repr(C,packed)]`) or `#[repr(transparent)]` attribute to `String`
    = note: `String` has unspecified layout
 
 error: `extern` fn uses type `ext_crate::AllowedUnsafeStruct`, which is not FFI-safe
-  --> $DIR/allow_improper_ctypes.rs:95:24
+  --> $DIR/allow-improper-ctypes.rs:95:24
    |
 LL | extern "C" fn fn3ou(e: ext_crate::AllowedUnsafeStruct) {}
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -78,7 +78,7 @@ LL | extern "C" fn fn3ou(e: ext_crate::AllowedUnsafeStruct) {}
    = note: `String` has unspecified layout
 
 error: `extern` callback uses type `&[A]`, which is not FFI-safe
-  --> $DIR/allow_improper_ctypes.rs:139:14
+  --> $DIR/allow-improper-ctypes.rs:139:14
    |
 LL |     combine: extern "C" fn(&[A]) -> A,
    |              ^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -88,15 +88,15 @@ LL |     combine: extern "C" fn(&[A]) -> A,
    = note: this reference to an unsized type contains metadata, which makes it incompatible with a C pointer
 
 error: `extern` callback uses type `FakeVTable<u32>`, which is not FFI-safe
-  --> $DIR/allow_improper_ctypes.rs:145:24
+  --> $DIR/allow-improper-ctypes.rs:145:24
    |
 LL | type FakeVTableMaker = extern "C" fn() -> FakeVTable<u32>;
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
    |
    = note: the function pointer to `extern "C" fn() -> FakeVTable<u32>` is FFI-unsafe due to `FakeVTable<u32>`
    = note: this struct/enum/union (`FakeVTable<u32>`) is FFI-unsafe due to a `(u32, usize)` field
 note: the type is defined here
-  --> $DIR/allow_improper_ctypes.rs:137:1
+  --> $DIR/allow-improper-ctypes.rs:137:1
    |
 LL | struct FakeVTable<A>{
    | ^^^^^^^^^^^^^^^^^^^^

tests/ui/lint/improper_ctypes/allow_improper_ctypes.stderr renamed to tests/ui/lint/improper-ctypes/allow-improper-ctypes.stderr

@@ -1,6 +1,9 @@
 #![crate_type = "lib"]
 #![deny(improper_c_fn_definitions, improper_c_callbacks)]
 
+// Issue: https://github.com/rust-lang/rust/issues/94223
+// ice when a FnPtr has an unsized array argument
+
 pub fn bad(f: extern "C" fn([u8])) {}
 //~^ ERROR `extern` callback uses type `[u8]`, which is not FFI-safe
 

tests/ui/lint/improper_ctypes/allow-phantomdata-in-ffi.rs renamed to tests/ui/lint/improper-ctypes/allow-phantomdata-in-ffi.rs

@@ -1,5 +1,5 @@
 error: `extern` callback uses type `[u8]`, which is not FFI-safe
-  --> $DIR/lint-94223.rs:4:15
+  --> $DIR/ice-fnptr-slicearg.rs:7:15
    |
 LL | pub fn bad(f: extern "C" fn([u8])) {}
    |               ^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -8,13 +8,13 @@ LL | pub fn bad(f: extern "C" fn([u8])) {}
    = help: consider using a raw pointer to the slice's first element (and a length) instead
    = note: slices have no C equivalent
 note: the lint level is defined here
-  --> $DIR/lint-94223.rs:2:36
+  --> $DIR/ice-fnptr-slicearg.rs:2:36
    |
 LL | #![deny(improper_c_fn_definitions, improper_c_callbacks)]
    |                                    ^^^^^^^^^^^^^^^^^^^^
 
 error: `extern` callback uses type `[u8]`, which is not FFI-safe
-  --> $DIR/lint-94223.rs:7:28
+  --> $DIR/ice-fnptr-slicearg.rs:10:28
    |
 LL | pub fn bad_twice(f: Result<extern "C" fn([u8]), extern "C" fn([u8])>) {}
    |                            ^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -24,7 +24,7 @@ LL | pub fn bad_twice(f: Result<extern "C" fn([u8]), extern "C" fn([u8])>) {}
    = note: slices have no C equivalent
 
 error: `extern` callback uses type `[u8]`, which is not FFI-safe
-  --> $DIR/lint-94223.rs:7:49
+  --> $DIR/ice-fnptr-slicearg.rs:10:49
    |
 LL | pub fn bad_twice(f: Result<extern "C" fn([u8]), extern "C" fn([u8])>) {}
    |                                                 ^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -34,7 +34,7 @@ LL | pub fn bad_twice(f: Result<extern "C" fn([u8]), extern "C" fn([u8])>) {}
    = note: slices have no C equivalent
 
 error: `extern` callback uses type `[u8]`, which is not FFI-safe
-  --> $DIR/lint-94223.rs:11:18
+  --> $DIR/ice-fnptr-slicearg.rs:14:18
    |
 LL | struct BadStruct(extern "C" fn([u8]));
    |                  ^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -44,7 +44,7 @@ LL | struct BadStruct(extern "C" fn([u8]));
    = note: slices have no C equivalent
 
 error: `extern` callback uses type `[u8]`, which is not FFI-safe
-  --> $DIR/lint-94223.rs:15:7
+  --> $DIR/ice-fnptr-slicearg.rs:18:7
    |
 LL |     A(extern "C" fn([u8])),
    |       ^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -54,7 +54,7 @@ LL |     A(extern "C" fn([u8])),
    = note: slices have no C equivalent
 
 error: `extern` callback uses type `[u8]`, which is not FFI-safe
-  --> $DIR/lint-94223.rs:20:7
+  --> $DIR/ice-fnptr-slicearg.rs:23:7
    |
 LL |     A(extern "C" fn([u8])),
    |       ^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -64,7 +64,7 @@ LL |     A(extern "C" fn([u8])),
    = note: slices have no C equivalent
 
 error: `extern` callback uses type `[u8]`, which is not FFI-safe
-  --> $DIR/lint-94223.rs:24:12
+  --> $DIR/ice-fnptr-slicearg.rs:27:12
    |
 LL | type Foo = extern "C" fn([u8]);
    |            ^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -74,7 +74,7 @@ LL | type Foo = extern "C" fn([u8]);
    = note: slices have no C equivalent
 
 error: `extern` callback uses type `Option<&<T as FooTrait>::FooType>`, which is not FFI-safe
-  --> $DIR/lint-94223.rs:31:20
+  --> $DIR/ice-fnptr-slicearg.rs:34:20
    |
 LL | pub type Foo2<T> = extern "C" fn(Option<&<T as FooTrait>::FooType>);
    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -84,7 +84,7 @@ LL | pub type Foo2<T> = extern "C" fn(Option<&<T as FooTrait>::FooType>);
    = note: enum has no representation hint
 
 error: `extern` callback uses type `FfiUnsafe`, which is not FFI-safe
-  --> $DIR/lint-94223.rs:41:17
+  --> $DIR/ice-fnptr-slicearg.rs:44:17
    |
 LL | pub static BAD: extern "C" fn(FfiUnsafe) = f;
    |                 ^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -93,13 +93,13 @@ LL | pub static BAD: extern "C" fn(FfiUnsafe) = f;
    = help: consider adding a `#[repr(C)]` (not `#[repr(C,packed)]`) or `#[repr(transparent)]` attribute to `FfiUnsafe`
    = note: `FfiUnsafe` has unspecified layout
 note: the type is defined here
-  --> $DIR/lint-94223.rs:34:1
+  --> $DIR/ice-fnptr-slicearg.rs:37:1
    |
 LL | pub struct FfiUnsafe;
    | ^^^^^^^^^^^^^^^^^^^^
 
 error: `extern` callback uses type `FfiUnsafe`, which is not FFI-safe
-  --> $DIR/lint-94223.rs:44:30
+  --> $DIR/ice-fnptr-slicearg.rs:47:30
    |
 LL | pub static BAD_TWICE: Result<extern "C" fn(FfiUnsafe), extern "C" fn(FfiUnsafe)> = Ok(f);
    |                              ^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -108,13 +108,13 @@ LL | pub static BAD_TWICE: Result<extern "C" fn(FfiUnsafe), extern "C" fn(FfiUns
    = help: consider adding a `#[repr(C)]` (not `#[repr(C,packed)]`) or `#[repr(transparent)]` attribute to `FfiUnsafe`
    = note: `FfiUnsafe` has unspecified layout
 note: the type is defined here
-  --> $DIR/lint-94223.rs:34:1
+  --> $DIR/ice-fnptr-slicearg.rs:37:1
    |
 LL | pub struct FfiUnsafe;
    | ^^^^^^^^^^^^^^^^^^^^
 
 error: `extern` callback uses type `FfiUnsafe`, which is not FFI-safe
-  --> $DIR/lint-94223.rs:44:56
+  --> $DIR/ice-fnptr-slicearg.rs:47:56
    |
 LL | pub static BAD_TWICE: Result<extern "C" fn(FfiUnsafe), extern "C" fn(FfiUnsafe)> = Ok(f);
    |                                                        ^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -123,13 +123,13 @@ LL | pub static BAD_TWICE: Result<extern "C" fn(FfiUnsafe), extern "C" fn(FfiUns
    = help: consider adding a `#[repr(C)]` (not `#[repr(C,packed)]`) or `#[repr(transparent)]` attribute to `FfiUnsafe`
    = note: `FfiUnsafe` has unspecified layout
 note: the type is defined here
-  --> $DIR/lint-94223.rs:34:1
+  --> $DIR/ice-fnptr-slicearg.rs:37:1
    |
 LL | pub struct FfiUnsafe;
    | ^^^^^^^^^^^^^^^^^^^^
 
 error: `extern` callback uses type `FfiUnsafe`, which is not FFI-safe
-  --> $DIR/lint-94223.rs:48:22
+  --> $DIR/ice-fnptr-slicearg.rs:51:22
    |
 LL | pub const BAD_CONST: extern "C" fn(FfiUnsafe) = f;
    |                      ^^^^^^^^^^^^^^^^^^^^^^^^ not FFI-safe
@@ -138,7 +138,7 @@ LL | pub const BAD_CONST: extern "C" fn(FfiUnsafe) = f;
    = help: consider adding a `#[repr(C)]` (not `#[repr(C,packed)]`) or `#[repr(transparent)]` attribute to `FfiUnsafe`
    = note: `FfiUnsafe` has unspecified layout
 note: the type is defined here
-  --> $DIR/lint-94223.rs:34:1
+  --> $DIR/ice-fnptr-slicearg.rs:37:1
    |
 LL | pub struct FfiUnsafe;
    | ^^^^^^^^^^^^^^^^^^^^

tests/ui/lint/improper_ctypes/auxiliary/extern_crate_types.rs renamed to tests/ui/lint/improper-ctypes/auxiliary/extern_crate_types.rs

@@ -1,6 +1,9 @@
 //@ check-pass
 #![deny(improper_ctypes)]
 
+// Issue: https://github.com/rust-lang/rust/issues/73249
+// "ICE: could not fully normalize"
+
 pub trait Foo {
     type Assoc: 'static;
 }

tests/ui/lint/improper_ctypes/lint-94223.rs renamed to tests/ui/lint/improper-ctypes/ice-fnptr-slicearg.rs

@@ -3,6 +3,9 @@
 #![feature(type_alias_impl_trait)]
 #![deny(improper_ctypes)]
 
+// Issue: https://github.com/rust-lang/rust/issues/73249
+// "ICE: could not fully normalize"
+
 trait Baz {}
 
 impl Baz for () {}

tests/ui/lint/improper_ctypes/lint-94223.stderr renamed to tests/ui/lint/improper-ctypes/ice-fnptr-slicearg.stderr

@@ -1,6 +1,9 @@
 #![feature(type_alias_impl_trait)]
 #![deny(improper_ctypes)]
 
+// Issue: https://github.com/rust-lang/rust/issues/73249
+// "ICE: could not fully normalize"
+
 pub trait Baz {}
 
 impl Baz for u32 {}

tests/ui/lint/improper_ctypes/mustpass-73249-1.rs renamed to tests/ui/lint/improper-ctypes/ice-fully-normalize-1.rs

@@ -1,18 +1,18 @@
 error: `extern` block uses type `A`, which is not FFI-safe
-  --> $DIR/lint-73249-5.rs:21:25
+  --> $DIR/ice-fully-normalize-3.rs:24:25
    |
 LL |     pub fn lint_me() -> A;
    |                         ^ not FFI-safe
    |
    = note: this struct/enum/union (`A`) is FFI-unsafe due to a `Qux` field
 note: the type is defined here
-  --> $DIR/lint-73249-5.rs:16:1
+  --> $DIR/ice-fully-normalize-3.rs:19:1
    |
 LL | pub struct A {
    | ^^^^^^^^^^^^
    = note: opaque types have no C equivalent
 note: the lint level is defined here
-  --> $DIR/lint-73249-5.rs:2:9
+  --> $DIR/ice-fully-normalize-3.rs:2:9
    |
 LL | #![deny(improper_ctypes)]
    |         ^^^^^^^^^^^^^^^