Skip to content

Commit 79f5c16

Browse files
committed
Auto merge of #128982 - saethlin:windows-debuginfo-tests, r=compiler-errors
Re-enable more debuginfo tests on Windows These tests used to be disabled on all Windows hosts. Now they're fully enabled or just disabled on windows-gnu with an issue citation that clearly explains why. The changes in this PR are not tested by PR CI, but I've tested it using try-jobs below. try-job: i686-msvc try-job: i686-mingw try-job: x86_64-mingw try-job: x86_64-msvc
2 parents 23f762d + 70320c1 commit 79f5c16

11 files changed

+8
-12
lines changed

tests/debuginfo/drop-locations.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
//@ ignore-windows
21
//@ ignore-android
32
//@ min-lldb-version: 310
43
//@ ignore-test: #128971

tests/debuginfo/embedded-visualizer.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//@ compile-flags:-g
22
//@ min-gdb-version: 8.1
33
//@ ignore-lldb
4-
//@ ignore-windows-gnu // emit_debug_gdb_scripts is disabled on Windows
4+
//@ ignore-windows-gnu: #128981
55

66
// === CDB TESTS ==================================================================================
77

tests/debuginfo/empty-string.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//@ ignore-windows failing on win32 bot
1+
//@ ignore-windows-gnu: #128981
22
//@ ignore-android: FIXME(#10381)
33
//@ compile-flags:-g
44
//@ min-gdb-version: 8.1

tests/debuginfo/issue-12886.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,11 @@
1-
//@ ignore-windows failing on 64-bit bots FIXME #17638
21
//@ ignore-lldb
32
//@ ignore-aarch64
43

54
//@ compile-flags:-g
65

76
// gdb-command:run
87
// gdb-command:next
9-
// gdb-check:[...]24[...]let s = Some(5).unwrap(); // #break
8+
// gdb-check:[...]23[...]let s = Some(5).unwrap(); // #break
109
// gdb-command:continue
1110

1211
#![feature(omit_gdb_pretty_printer_section)]

tests/debuginfo/macro-stepping.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
//@ ignore-windows
21
//@ ignore-android
32
//@ ignore-aarch64
43
//@ min-lldb-version: 1800

tests/debuginfo/numeric-types.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
//@ compile-flags:-g
22

33
//@ min-gdb-version: 8.1
4-
//@ ignore-windows-gnu // emit_debug_gdb_scripts is disabled on Windows
4+
//@ ignore-windows-gnu: #128981
55

66
// Tests the visualizations for `NonZero<T>`, `Wrapping<T>` and
77
// `Atomic{Bool,I8,I16,I32,I64,Isize,U8,U16,U32,U64,Usize}` located in `libcore.natvis`.

tests/debuginfo/pretty-huge-vec.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//@ ignore-windows failing on win32 bot
1+
//@ ignore-windows-gnu: #128981
22
//@ ignore-android: FIXME(#10381)
33
//@ compile-flags:-g
44
//@ min-gdb-version: 8.1

tests/debuginfo/pretty-slices.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
//@ ignore-android: FIXME(#10381)
2-
//@ ignore-windows
2+
//@ ignore-windows-gnu: #128981
33
//@ compile-flags:-g
44

55
// gdb-command: run

tests/debuginfo/pretty-std-collections.rs

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
//@ ignore-windows failing on win32 bot
21
//@ ignore-android: FIXME(#10381)
32
//@ ignore-windows-gnu: #128981
43
//@ compile-flags:-g

tests/debuginfo/pretty-uninitialized-vec.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
//@ ignore-windows failing on win32 bot
1+
//@ ignore-windows-gnu: #128981
22
//@ ignore-android: FIXME(#10381)
33
//@ compile-flags:-g
44
//@ min-gdb-version: 8.1

tests/debuginfo/thread-names.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
//@[macos] only-macos
55
//@[win] only-windows
66
//@ ignore-sgx
7-
//@ ignore-windows-gnu
7+
//@ ignore-windows-gnu: gdb on windows-gnu does not print thread names
88

99
// === GDB TESTS ==================================================================================
1010
//

0 commit comments

Comments
 (0)