Skip to content

Commit 898ecf0

Browse files
committed
Enable f128 tests on all non-buggy platforms 🎉
With the `compiler-builtins` update to 0.1.137 [1], we now provide symbols necessary to work with `f128` everywhere. This means that we are no longer restricted to 64-bit linux, and can enable tests by default. There are still a handful of platforms that need to remain disabled because of bugs. This patch additionally disables the following: 1. MIPS [2] 2. 32-bit x86 [3] Math support is still off by default since those symbols are not yet available. [1]: #132433 [2]: llvm/llvm-project#96432 [3]: llvm/llvm-project#77401
1 parent 95ecf0c commit 898ecf0

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

library/std/build.rs

+11-7
Original file line numberDiff line numberDiff line change
@@ -122,19 +122,23 @@ fn main() {
122122
_ if is_miri => true,
123123
// Unsupported <https://github.com/llvm/llvm-project/issues/94434>
124124
("arm64ec", _) => false,
125-
// ABI and precision bugs <https://github.com/rust-lang/rust/issues/125109>
126-
// <https://github.com/rust-lang/rust/issues/125102>
127-
("powerpc" | "powerpc64", _) => false,
125+
// Selection bug <https://github.com/llvm/llvm-project/issues/96432>
126+
("mips" | "mips64" | "mips32r6" | "mips64r6", _) => false,
128127
// Selection bug <https://github.com/llvm/llvm-project/issues/95471>
129128
("nvptx64", _) => false,
129+
// ABI and precision bugs <https://github.com/rust-lang/rust/issues/125109>
130+
("powerpc" | "powerpc64", _) => false,
130131
// ABI unsupported <https://github.com/llvm/llvm-project/issues/41838>
131132
("sparc", _) => false,
133+
// Stack alignment bug <https://github.com/llvm/llvm-project/issues/77401>. NB: tests may
134+
// not fail if our compiler-builtins is linked.
135+
("x86", _) => false,
132136
// MinGW ABI bugs <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115054>
133137
("x86_64", "windows") if target_env == "gnu" && target_abi != "llvm" => false,
134-
// 64-bit Linux is about the only platform to have f128 symbols by default
135-
(_, "linux") if target_pointer_width == 64 => true,
136-
// Almost all OSs are missing symbol. compiler-builtins will have to add them.
137-
_ => false,
138+
// There are no known problems on other platforms, so the only requirement is that symbols
139+
// are available. `compiler-builtins` provides all symbols required for core `f128`
140+
// support, so this should work for everything else.
141+
_ => true,
138142
};
139143

140144
// Configure platforms that have reliable basics but may have unreliable math.

0 commit comments

Comments
 (0)