Skip to content

Commit ce450f8

Browse files
committed
Use the 64b inner:monotonize() implementation not the 128b one for aarch64
aarch64 prior to v8.4 (FEAT_LSE2) doesn't have an instruction that guarantees untorn 128b reads except for completing a 128b load/store exclusive pair (ldxp/stxp) or compare-and-swap (casp) successfully. The requirement to complete a 128b read+write atomic is actually more expensive and more unfair than the previous implementation of monotonize() which used a Mutex on aarch64, especially at large core counts. For aarch64 switch to the 64b atomic implementation which is about 13x faster for a benchmark that involves many calls to Instant::now().
1 parent 72a51c3 commit ce450f8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

library/std/src/time/monotonic.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ pub(super) fn monotonize(raw: time::Instant) -> time::Instant {
55
inner::monotonize(raw)
66
}
77

8-
#[cfg(all(target_has_atomic = "64", not(target_has_atomic = "128")))]
8+
#[cfg(any(all(target_has_atomic = "64", not(target_has_atomic = "128")), target_arch = "aarch64"))]
99
pub mod inner {
1010
use crate::sync::atomic::AtomicU64;
1111
use crate::sync::atomic::Ordering::*;
@@ -70,7 +70,7 @@ pub mod inner {
7070
}
7171
}
7272

73-
#[cfg(target_has_atomic = "128")]
73+
#[cfg(all(target_has_atomic = "128", not(target_arch = "aarch64")))]
7474
pub mod inner {
7575
use crate::sync::atomic::AtomicU128;
7676
use crate::sync::atomic::Ordering::*;

0 commit comments

Comments
 (0)