Make feature flag incomplete

spastorino · spastorino · commit d7104dc3f5c6 · 2025-03-06T18:06:48.000-03:00
diff --git a/compiler/rustc_feature/src/unstable.rs b/compiler/rustc_feature/src/unstable.rs
@@ -474,7 +474,7 @@ declare_features! (
     /// Allows `dyn* Trait` objects.
     (incomplete, dyn_star, "1.65.0", Some(102425)),
     /// Allows the .use postfix syntax `x.use` and use closures `use |x| { ... }`
-    (unstable, ergonomic_clones, "CURRENT_RUSTC_VERSION", Some(132290)),
+    (incomplete, ergonomic_clones, "CURRENT_RUSTC_VERSION", Some(132290)),
     /// Allows exhaustive pattern matching on types that contain uninhabited types.
     (unstable, exhaustive_patterns, "1.13.0", Some(51085)),
     /// Allows explicit tail calls via `become` expression.
diff --git a/tests/ui/ergonomic-clones/async/basic.rs b/tests/ui/ergonomic-clones/async/basic.rs
@@ -2,6 +2,7 @@
 //@ edition:2018
 
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 use std::future::Future;
 
diff --git a/tests/ui/ergonomic-clones/async/edition-2015.rs b/tests/ui/ergonomic-clones/async/edition-2015.rs
@@ -1,4 +1,5 @@
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn main() {
     async use {};
diff --git a/tests/ui/ergonomic-clones/async/edition-2015.stderr b/tests/ui/ergonomic-clones/async/edition-2015.stderr
@@ -1,5 +1,5 @@
 error: `async use` blocks are only allowed in Rust 2018 or later
-  --> $DIR/edition-2015.rs:4:5
+  --> $DIR/edition-2015.rs:5:5
    |
 LL |     async use {};
    |     ^^^^^^^^^
diff --git a/tests/ui/ergonomic-clones/async/local-type.rs b/tests/ui/ergonomic-clones/async/local-type.rs
@@ -2,6 +2,7 @@
 //@ edition:2018
 
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn main() {
     let _ = async use |x: x| x; //~ ERROR expected type
diff --git a/tests/ui/ergonomic-clones/async/local-type.stderr b/tests/ui/ergonomic-clones/async/local-type.stderr
@@ -1,11 +1,11 @@
 error[E0573]: expected type, found local variable `x`
-  --> $DIR/local-type.rs:7:27
+  --> $DIR/local-type.rs:8:27
    |
 LL |     let _ = async use |x: x| x;
    |                           ^ not a type
 
 error[E0573]: expected type, found local variable `x`
-  --> $DIR/local-type.rs:8:36
+  --> $DIR/local-type.rs:9:36
    |
 LL |     let _ = async use |x: bool| -> x { x };
    |                                    ^ not a type
diff --git a/tests/ui/ergonomic-clones/closure/basic.rs b/tests/ui/ergonomic-clones/closure/basic.rs
@@ -1,6 +1,7 @@
 //@ check-pass
 
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 use std::clone::UseCloned;
 use std::future::Future;
diff --git a/tests/ui/ergonomic-clones/closure/fn-once.rs b/tests/ui/ergonomic-clones/closure/fn-once.rs
@@ -1,4 +1,5 @@
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn get_closure() -> Box<dyn Fn() -> Vec<u8>> {
     let vec = vec![1u8, 2u8];
diff --git a/tests/ui/ergonomic-clones/closure/fn-once.stderr b/tests/ui/ergonomic-clones/closure/fn-once.stderr
@@ -1,5 +1,5 @@
 error[E0525]: expected a closure that implements the `Fn` trait, but this closure only implements `FnOnce`
-  --> $DIR/fn-once.rs:6:19
+  --> $DIR/fn-once.rs:7:19
    |
 LL |     let closure = use || {
    |                   ^^^^^^ this closure implements `FnOnce`, not `Fn`
@@ -9,7 +9,7 @@ LL |         vec
 LL |     Box::new(closure)
    |     ----------------- the requirement to implement `Fn` derives from here
    |
-   = note: required for the cast from `Box<{closure@$DIR/fn-once.rs:6:19: 6:25}>` to `Box<(dyn Fn() -> Vec<u8> + 'static)>`
+   = note: required for the cast from `Box<{closure@$DIR/fn-once.rs:7:19: 7:25}>` to `Box<(dyn Fn() -> Vec<u8> + 'static)>`
 
 error: aborting due to 1 previous error
 
diff --git a/tests/ui/ergonomic-clones/closure/immutable-outer-variable.fixed b/tests/ui/ergonomic-clones/closure/immutable-outer-variable.fixed
@@ -3,6 +3,7 @@
 // Point at the captured immutable outer variable
 
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn foo(mut f: Box<dyn FnMut()>) {
     f();
diff --git a/tests/ui/ergonomic-clones/closure/immutable-outer-variable.rs b/tests/ui/ergonomic-clones/closure/immutable-outer-variable.rs
@@ -3,6 +3,7 @@
 // Point at the captured immutable outer variable
 
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn foo(mut f: Box<dyn FnMut()>) {
     f();
diff --git a/tests/ui/ergonomic-clones/closure/immutable-outer-variable.stderr b/tests/ui/ergonomic-clones/closure/immutable-outer-variable.stderr
@@ -1,5 +1,5 @@
 error[E0594]: cannot assign to `y`, as it is not declared as mutable
-  --> $DIR/immutable-outer-variable.rs:13:25
+  --> $DIR/immutable-outer-variable.rs:14:25
    |
 LL |     foo(Box::new(use || y = !y) as Box<_>);
    |                         ^^^^^^ cannot assign
diff --git a/tests/ui/ergonomic-clones/closure/local-type.rs b/tests/ui/ergonomic-clones/closure/local-type.rs
@@ -1,6 +1,7 @@
 // Check that using the parameter name in its type does not ICE.
 
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn main() {
     let _ = use |x: x| x; //~ ERROR expected type
diff --git a/tests/ui/ergonomic-clones/closure/local-type.stderr b/tests/ui/ergonomic-clones/closure/local-type.stderr
@@ -1,11 +1,11 @@
 error[E0573]: expected type, found local variable `x`
-  --> $DIR/local-type.rs:6:21
+  --> $DIR/local-type.rs:7:21
    |
 LL |     let _ = use |x: x| x;
    |                     ^ not a type
 
 error[E0573]: expected type, found local variable `x`
-  --> $DIR/local-type.rs:7:30
+  --> $DIR/local-type.rs:8:30
    |
 LL |     let _ = use |x: bool| -> x { x };
    |                              ^ not a type
diff --git a/tests/ui/ergonomic-clones/closure/mutation.rs b/tests/ui/ergonomic-clones/closure/mutation.rs
@@ -1,6 +1,7 @@
 //@ check-pass
 
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn main() {
     let mut my_var = false;
diff --git a/tests/ui/ergonomic-clones/closure/mutation2.rs b/tests/ui/ergonomic-clones/closure/mutation2.rs
@@ -1,4 +1,5 @@
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn main() {
     let mut my_var = false;
diff --git a/tests/ui/ergonomic-clones/closure/mutation2.stderr b/tests/ui/ergonomic-clones/closure/mutation2.stderr
@@ -1,5 +1,5 @@
 error[E0596]: cannot borrow `callback` as mutable, as it is not declared as mutable
-  --> $DIR/mutation2.rs:8:5
+  --> $DIR/mutation2.rs:9:5
    |
 LL |         my_var = true;
    |         ------ calling `callback` requires mutable binding due to possible mutation of `my_var`
diff --git a/tests/ui/ergonomic-clones/closure/nested.rs b/tests/ui/ergonomic-clones/closure/nested.rs
@@ -1,6 +1,7 @@
 //@ run-pass
 
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 use std::clone::UseCloned;
 
diff --git a/tests/ui/ergonomic-clones/closure/once-move-out-on-heap.rs b/tests/ui/ergonomic-clones/closure/once-move-out-on-heap.rs
@@ -2,6 +2,7 @@
 // Testing guarantees provided by once functions.
 
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 use std::sync::Arc;
 
diff --git a/tests/ui/ergonomic-clones/closure/parse.rs b/tests/ui/ergonomic-clones/closure/parse.rs
@@ -1,4 +1,5 @@
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn parse1() {
     || use {
diff --git a/tests/ui/ergonomic-clones/closure/parse.stderr b/tests/ui/ergonomic-clones/closure/parse.stderr
@@ -1,5 +1,5 @@
 error: expected one of `async`, `|`, or `||`, found `{`
-  --> $DIR/parse.rs:4:12
+  --> $DIR/parse.rs:5:12
    |
 LL |     || use {
    |     --     ^ expected one of `async`, `|`, or `||`
@@ -13,13 +13,13 @@ LL ~     || { use {
    |
 
 error: expected one of `async`, `|`, or `||`, found keyword `use`
-  --> $DIR/parse.rs:10:10
+  --> $DIR/parse.rs:11:10
    |
 LL |     move use || {
    |          ^^^ expected one of `async`, `|`, or `||`
 
 error: expected one of `async`, `|`, or `||`, found keyword `move`
-  --> $DIR/parse.rs:16:9
+  --> $DIR/parse.rs:17:9
    |
 LL |     use move || {
    |         ^^^^ expected one of `async`, `|`, or `||`
diff --git a/tests/ui/ergonomic-clones/closure/print-verbose.rs b/tests/ui/ergonomic-clones/closure/print-verbose.rs
@@ -1,6 +1,7 @@
 //@ compile-flags: -Zverbose-internals
 
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn to_fn_once<F: FnOnce()>(f: F) -> F {
     f
diff --git a/tests/ui/ergonomic-clones/closure/print-verbose.stderr b/tests/ui/ergonomic-clones/closure/print-verbose.stderr
@@ -1,5 +1,5 @@
 error[E0382]: use of moved value: `c`
-  --> $DIR/print-verbose.rs:21:5
+  --> $DIR/print-verbose.rs:22:5
    |
 LL |     let c = to_fn_once(use || {
    |         - move occurs because `c` has type `{f<T>::{closure#0} closure_kind_ty=i32 closure_sig_as_fn_ptr_ty=extern "rust-call" fn(()) upvar_tys=(Foo<&'?9 str>, T)}`, which does not implement the `Copy` trait
@@ -10,7 +10,7 @@ LL |     c();
    |     ^ value used here after move
    |
 note: this value implements `FnOnce`, which causes it to be moved when called
-  --> $DIR/print-verbose.rs:20:5
+  --> $DIR/print-verbose.rs:21:5
    |
 LL |     c();
    |     ^
diff --git a/tests/ui/ergonomic-clones/closure/print.rs b/tests/ui/ergonomic-clones/closure/print.rs
@@ -1,4 +1,5 @@
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn to_fn_once<F: FnOnce()>(f: F) -> F {
     f
diff --git a/tests/ui/ergonomic-clones/closure/print.stderr b/tests/ui/ergonomic-clones/closure/print.stderr
@@ -1,16 +1,16 @@
 error[E0382]: use of moved value: `c`
-  --> $DIR/print.rs:19:5
+  --> $DIR/print.rs:20:5
    |
 LL |     let c = to_fn_once(use || {
-   |         - move occurs because `c` has type `{closure@$DIR/print.rs:14:24: 14:30}`, which does not implement the `Copy` trait
+   |         - move occurs because `c` has type `{closure@$DIR/print.rs:15:24: 15:30}`, which does not implement the `Copy` trait
 ...
 LL |     c();
    |     --- `c` moved due to this call
 LL |     c();
    |     ^ value used here after move
    |
 note: this value implements `FnOnce`, which causes it to be moved when called
-  --> $DIR/print.rs:18:5
+  --> $DIR/print.rs:19:5
    |
 LL |     c();
    |     ^
diff --git a/tests/ui/ergonomic-clones/closure/with-binders.rs b/tests/ui/ergonomic-clones/closure/with-binders.rs
@@ -3,6 +3,7 @@
 
 #![feature(closure_lifetime_binder)]
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn main() {
     for<'a> use || -> () {};
diff --git a/tests/ui/ergonomic-clones/dotuse/basic.rs b/tests/ui/ergonomic-clones/dotuse/basic.rs
@@ -1,6 +1,7 @@
 //@ check-pass
 
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 use std::clone::UseCloned;
 
diff --git a/tests/ui/ergonomic-clones/dotuse/parse.rs b/tests/ui/ergonomic-clones/dotuse/parse.rs
@@ -1,4 +1,5 @@
 #![feature(ergonomic_clones)]
+#![allow(incomplete_features)]
 
 fn parse1() {
     1.use!;
diff --git a/tests/ui/ergonomic-clones/dotuse/parse.stderr b/tests/ui/ergonomic-clones/dotuse/parse.stderr
@@ -1,29 +1,29 @@
 error: expected one of `.`, `;`, `?`, `}`, or an operator, found `!`
-  --> $DIR/parse.rs:4:10
+  --> $DIR/parse.rs:5:10
    |
 LL |     1.use!;
    |          ^ expected one of `.`, `;`, `?`, `}`, or an operator
 
 error: expected one of `.`, `;`, `?`, `}`, or an operator, found `!`
-  --> $DIR/parse.rs:9:10
+  --> $DIR/parse.rs:10:10
    |
 LL |     1.use!(2);
    |          ^ expected one of `.`, `;`, `?`, `}`, or an operator
 
 error: expected one of `.`, `;`, `?`, `}`, or an operator, found `2`
-  --> $DIR/parse.rs:14:11
+  --> $DIR/parse.rs:15:11
    |
 LL |     1.use 2;
    |           ^ expected one of `.`, `;`, `?`, `}`, or an operator
 
 error: expected one of `.`, `;`, `?`, `}`, or an operator, found `2`
-  --> $DIR/parse.rs:19:12
+  --> $DIR/parse.rs:20:12
    |
 LL |     1.use? 2;
    |            ^ expected one of `.`, `;`, `?`, `}`, or an operator
 
 error: incorrect use of `use`
-  --> $DIR/parse.rs:24:10
+  --> $DIR/parse.rs:25:10
    |
 LL |     1.use();
    |          ^^
@@ -35,13 +35,13 @@ LL +     1.use;
    |
 
 error: expected one of `.`, `;`, `?`, `}`, or an operator, found `{`
-  --> $DIR/parse.rs:34:11
+  --> $DIR/parse.rs:35:11
    |
 LL |     1.use { 2 };
    |           ^ expected one of `.`, `;`, `?`, `}`, or an operator
 
 error[E0618]: expected function, found `{integer}`
-  --> $DIR/parse.rs:29:5
+  --> $DIR/parse.rs:30:5
    |
 LL |     1.use(2);
    |     ^^^^^---

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`#![feature(ergonomic_clones)]`
	`2`	`+#![allow(incomplete_features)]`
`2`	`3`
`3`	`4`	`fn main() {`
`4`	`5`	`async use {};`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	error: `async use` blocks are only allowed in Rust 2018 or later
`2`		`- --> $DIR/edition-2015.rs:4:5`
	`2`	`+ --> $DIR/edition-2015.rs:5:5`
`3`	`3`	`\|`
`4`	`4`	`LL \| async use {};`
`5`	`5`	`\| ^^^^^^^^^`
Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,11 @@`
`1`	`1`	error[E0573]: expected type, found local variable `x`
`2`		`- --> $DIR/local-type.rs:7:27`
	`2`	`+ --> $DIR/local-type.rs:8:27`
`3`	`3`	`\|`
`4`	`4`	`LL \| let _ = async use \|x: x\| x;`
`5`	`5`	`\| ^ not a type`
`6`	`6`
`7`	`7`	error[E0573]: expected type, found local variable `x`
`8`		`- --> $DIR/local-type.rs:8:36`
	`8`	`+ --> $DIR/local-type.rs:9:36`
`9`	`9`	`\|`
`10`	`10`	`LL \| let _ = async use \|x: bool\| -> x { x };`
`11`	`11`	`\| ^ not a type`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	error[E0525]: expected a closure that implements the `Fn` trait, but this closure only implements `FnOnce`
`2`		`- --> $DIR/fn-once.rs:6:19`
	`2`	`+ --> $DIR/fn-once.rs:7:19`
`3`	`3`	`\|`
`4`	`4`	`LL \| let closure = use \|\| {`
`5`	`5`	\| ^^^^^^ this closure implements `FnOnce`, not `Fn`
`@@ -9,7 +9,7 @@ LL \| vec`
`9`	`9`	`LL \| Box::new(closure)`
`10`	`10`	\| ----------------- the requirement to implement `Fn` derives from here
`11`	`11`	`\|`
`12`		- = note: required for the cast from `Box<{closure@$DIR/fn-once.rs:6:19: 6:25}>` to `Box<(dyn Fn() -> Vec<u8> + 'static)>`
	`12`	+ = note: required for the cast from `Box<{closure@$DIR/fn-once.rs:7:19: 7:25}>` to `Box<(dyn Fn() -> Vec<u8> + 'static)>`
`13`	`13`
`14`	`14`	`error: aborting due to 1 previous error`
`15`	`15`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	error[E0594]: cannot assign to `y`, as it is not declared as mutable
`2`		`- --> $DIR/immutable-outer-variable.rs:13:25`
	`2`	`+ --> $DIR/immutable-outer-variable.rs:14:25`
`3`	`3`	`\|`
`4`	`4`	`LL \| foo(Box::new(use \|\| y = !y) as Box<_>);`
`5`	`5`	`\| ^^^^^^ cannot assign`
Original file line number	Diff line number	Diff line change
`@@ -1,11 +1,11 @@`
`1`	`1`	error[E0573]: expected type, found local variable `x`
`2`		`- --> $DIR/local-type.rs:6:21`
	`2`	`+ --> $DIR/local-type.rs:7:21`
`3`	`3`	`\|`
`4`	`4`	`LL \| let _ = use \|x: x\| x;`
`5`	`5`	`\| ^ not a type`
`6`	`6`
`7`	`7`	error[E0573]: expected type, found local variable `x`
`8`		`- --> $DIR/local-type.rs:7:30`
	`8`	`+ --> $DIR/local-type.rs:8:30`
`9`	`9`	`\|`
`10`	`10`	`LL \| let _ = use \|x: bool\| -> x { x };`
`11`	`11`	`\| ^ not a type`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	error[E0596]: cannot borrow `callback` as mutable, as it is not declared as mutable
`2`		`- --> $DIR/mutation2.rs:8:5`
	`2`	`+ --> $DIR/mutation2.rs:9:5`
`3`	`3`	`\|`
`4`	`4`	`LL \| my_var = true;`
`5`	`5`	\| ------ calling `callback` requires mutable binding due to possible mutation of `my_var`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	error: expected one of `async`, `\|`, or `\|\|`, found `{`
`2`		`- --> $DIR/parse.rs:4:12`
	`2`	`+ --> $DIR/parse.rs:5:12`
`3`	`3`	`\|`
`4`	`4`	`LL \| \|\| use {`
`5`	`5`	\| -- ^ expected one of `async`, `\|`, or `\|\|`
`@@ -13,13 +13,13 @@ LL ~ \|\| { use {`
`13`	`13`	`\|`
`14`	`14`
`15`	`15`	error: expected one of `async`, `\|`, or `\|\|`, found keyword `use`
`16`		`- --> $DIR/parse.rs:10:10`
	`16`	`+ --> $DIR/parse.rs:11:10`
`17`	`17`	`\|`
`18`	`18`	`LL \| move use \|\| {`
`19`	`19`	\| ^^^ expected one of `async`, `\|`, or `\|\|`
`20`	`20`
`21`	`21`	error: expected one of `async`, `\|`, or `\|\|`, found keyword `move`
`22`		`- --> $DIR/parse.rs:16:9`
	`22`	`+ --> $DIR/parse.rs:17:9`
`23`	`23`	`\|`
`24`	`24`	`LL \| use move \|\| {`
`25`	`25`	\| ^^^^ expected one of `async`, `\|`, or `\|\|`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`//@ compile-flags: -Zverbose-internals`
`2`	`2`
`3`	`3`	`#![feature(ergonomic_clones)]`
	`4`	`+#![allow(incomplete_features)]`
`4`	`5`
`5`	`6`	`fn to_fn_once<F: FnOnce()>(f: F) -> F {`
`6`	`7`	`f`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	error[E0382]: use of moved value: `c`
`2`		`- --> $DIR/print-verbose.rs:21:5`
	`2`	`+ --> $DIR/print-verbose.rs:22:5`
`3`	`3`	`\|`
`4`	`4`	`LL \| let c = to_fn_once(use \|\| {`
`5`	`5`	\| - move occurs because `c` has type `{f<T>::{closure#0} closure_kind_ty=i32 closure_sig_as_fn_ptr_ty=extern "rust-call" fn(()) upvar_tys=(Foo<&'?9 str>, T)}`, which does not implement the `Copy` trait
`@@ -10,7 +10,7 @@ LL \| c();`
`10`	`10`	`\| ^ value used here after move`
`11`	`11`	`\|`
`12`	`12`	note: this value implements `FnOnce`, which causes it to be moved when called
`13`		`- --> $DIR/print-verbose.rs:20:5`
	`13`	`+ --> $DIR/print-verbose.rs:21:5`
`14`	`14`	`\|`
`15`	`15`	`LL \| c();`
`16`	`16`	`\| ^`