Skip to content

Commit d85d4db

Browse files
taiki-etaiki-e
committed
Stabilize s390x inline assembly
1 parent 7c7bb7d commit d85d4db

File tree

4 files changed

+5
-21
lines changed

4 files changed

+5
-21
lines changed

‎compiler/rustc_ast_lowering/src/asm.rs

+1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> {
4848
| asm::InlineAsmArch::RiscV32
4949
| asm::InlineAsmArch::RiscV64
5050
| asm::InlineAsmArch::LoongArch64
51+
| asm::InlineAsmArch::S390x
5152
);
5253
if !is_stable && !self.tcx.features().asm_experimental_arch() {
5354
feature_err(

‎src/doc/unstable-book/src/language-features/asm-experimental-arch.md

+2-19
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ This feature tracks `asm!` and `global_asm!` support for the following architect
1818
- MSP430
1919
- M68k
2020
- CSKY
21-
- s390x
2221
- Arm64EC
2322

2423
## Register classes
@@ -50,11 +49,6 @@ This feature tracks `asm!` and `global_asm!` support for the following architect
5049
| M68k | `reg_addr` | `a[0-3]` | `a` |
5150
| CSKY | `reg` | `r[0-31]` | `r` |
5251
| CSKY | `freg` | `f[0-31]` | `f` |
53-
| s390x | `reg` | `r[0-10]`, `r[12-14]` | `r` |
54-
| s390x | `reg_addr` | `r[1-10]`, `r[12-14]` | `a` |
55-
| s390x | `freg` | `f[0-15]` | `f` |
56-
| s390x | `vreg` | `v[0-31]` | Only clobbers |
57-
| s390x | `areg` | `a[2-15]` | Only clobbers |
5852
| Arm64EC | `reg` | `x[0-12]`, `x[15-22]`, `x[25-27]`, `x30` | `r` |
5953
| Arm64EC | `vreg` | `v[0-15]` | `w` |
6054
| Arm64EC | `vreg_low16` | `v[0-15]` | `x` |
@@ -91,10 +85,6 @@ This feature tracks `asm!` and `global_asm!` support for the following architect
9185
| M68k | `reg_data` | None | `i8`, `i16`, `i32` |
9286
| CSKY | `reg` | None | `i8`, `i16`, `i32` |
9387
| CSKY | `freg` | None | `f32`, |
94-
| s390x | `reg`, `reg_addr` | None | `i8`, `i16`, `i32`, `i64` |
95-
| s390x | `freg` | None | `f32`, `f64` |
96-
| s390x | `vreg` | N/A | Only clobbers |
97-
| s390x | `areg` | N/A | Only clobbers |
9888
| Arm64EC | `reg` | None | `i8`, `i16`, `i32`, `f32`, `i64`, `f64` |
9989
| Arm64EC | `vreg` | None | `i8`, `i16`, `i32`, `f32`, `i64`, `f64`, <br> `i8x8`, `i16x4`, `i32x2`, `i64x1`, `f32x2`, `f64x1`, <br> `i8x16`, `i16x8`, `i32x4`, `i64x2`, `f32x4`, `f64x2` |
10090

@@ -144,8 +134,8 @@ This feature tracks `asm!` and `global_asm!` support for the following architect
144134

145135
| Architecture | Unsupported register | Reason |
146136
| ------------ | --------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
147-
| All | `sp`, `r15` (s390x) | The stack pointer must be restored to its original value at the end of an asm code block. |
148-
| All | `fr` (Hexagon), `$fp` (MIPS), `Y` (AVR), `r4` (MSP430), `a6` (M68k), `r11` (s390x), `x29` (Arm64EC) | The frame pointer cannot be used as an input or output. |
137+
| All | `sp` | The stack pointer must be restored to its original value at the end of an asm code block. |
138+
| All | `fr` (Hexagon), `$fp` (MIPS), `Y` (AVR), `r4` (MSP430), `a6` (M68k), `x29` (Arm64EC) | The frame pointer cannot be used as an input or output. |
149139
| All | `r19` (Hexagon), `x19` (Arm64EC) | This is used internally by LLVM as a "base pointer" for functions with complex stack frames. |
150140
| MIPS | `$0` or `$zero` | This is a constant zero register which can't be modified. |
151141
| MIPS | `$1` or `$at` | Reserved for assembler. |
@@ -162,8 +152,6 @@ This feature tracks `asm!` and `global_asm!` support for the following architect
162152
| CSKY | `r15` | This is the link register. |
163153
| CSKY | `r[26-30]` | Reserved by its ABI. |
164154
| CSKY | `r31` | This is the TLS register. |
165-
| s390x | `c[0-15]` | Reserved by the kernel. |
166-
| s390x | `a[0-1]` | Reserved for system use. |
167155
| Arm64EC | `xzr` | This is a constant zero register which can't be modified. |
168156
| Arm64EC | `x18` | This is an OS-reserved register. |
169157
| Arm64EC | `x13`, `x14`, `x23`, `x24`, `x28`, `v[16-31]` | These are AArch64 registers that are not supported for Arm64EC. |
@@ -182,9 +170,6 @@ This feature tracks `asm!` and `global_asm!` support for the following architect
182170
| PowerPC | `reg` | None | `0` | None |
183171
| PowerPC | `reg_nonzero` | None | `3` | None |
184172
| PowerPC | `freg` | None | `0` | None |
185-
| s390x | `reg` | None | `%r0` | None |
186-
| s390x | `reg_addr` | None | `%r1` | None |
187-
| s390x | `freg` | None | `%f0` | None |
188173
| CSKY | `reg` | None | `r0` | None |
189174
| CSKY | `freg` | None | `f0` | None |
190175
| Arm64EC | `reg` | None | `x0` | `x` |
@@ -207,8 +192,6 @@ These flags registers must be restored upon exiting the asm block if the `preser
207192
- The status register `r2`.
208193
- M68k
209194
- The condition code register `ccr`.
210-
- s390x
211-
- The condition code register `cc`.
212195
- Arm64EC
213196
- Condition flags (`NZCV` register).
214197
- Floating-point status (`FPSR` register).

‎tests/assembly/asm/s390x-types.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
//@[s390x] needs-llvm-components: systemz
55
//@ compile-flags: -Zmerge-functions=disabled
66

7-
#![feature(no_core, lang_items, rustc_attrs, repr_simd, asm_experimental_arch)]
7+
#![feature(no_core, lang_items, rustc_attrs, repr_simd)]
88
#![crate_type = "rlib"]
99
#![no_core]
1010
#![allow(asm_sub_register, non_camel_case_types)]

‎tests/codegen/asm/s390x-clobbers.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
//@[s390x] needs-llvm-components: systemz
44

55
#![crate_type = "rlib"]
6-
#![feature(no_core, rustc_attrs, lang_items, asm_experimental_arch)]
6+
#![feature(no_core, rustc_attrs, lang_items)]
77
#![no_core]
88

99
#[lang = "sized"]

0 commit comments

Comments
 (0)