Skip to content

Tracking Issue for NEON fp16 intrinsics #136306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks
mrkajetanp opened this issue Jan 30, 2025 · 3 comments
Open
3 tasks

Tracking Issue for NEON fp16 intrinsics #136306

mrkajetanp opened this issue Jan 30, 2025 · 3 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@mrkajetanp
Copy link
Contributor

mrkajetanp commented Jan 30, 2025

This is a tracking issue for NEON fp16 intrinsics.
The feature gate for the issue is #![feature(stdarch_neon_fp16)].

This feature depends on the following PRs:

Public API

// core::arch::aarch64

fn vadd_f16(..);
(...)

Steps

  • Implemenation
  • Final comment period (FCP)
  • Stabilisation PR

Implementation history

TODO

@mrkajetanp mrkajetanp added the C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC label Jan 30, 2025
@Amanieu Amanieu added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. I-libs-api-nominated Nominated for discussion during a libs-api team meeting. and removed I-libs-api-nominated Nominated for discussion during a libs-api team meeting. labels Jun 2, 2025
@Amanieu
Copy link
Member

Amanieu commented Jun 2, 2025

Proposing stabilization of intrinsics that use f16xN vector types, but not intrinsics that use f16 directly since that is still blocked on stabilization of f16 (#116909 ).

@rfcbot merge

@rfcbot
Copy link
Collaborator

rfcbot commented Jun 2, 2025

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jun 2, 2025
@adamgemmell
Copy link
Contributor

I did a quick sanity test that the behavioural testing (intrinsic-test, comparing Rust vs Clang) and signature verification (stdarch-verify, comparing the Rust function definitions with the JSON reference file) for these intrinsics was working correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants