compiletest: Support --extern options with proc-macro directive
#151258
+60
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-compiletest
Enselic
force-pushed
the
proc-macro-priv
branch
from
644786e to
b966c10
Compare
This comment has been minimized.
This comment has been minimized.
So that `pub-priv1.rs` test does not have to (ab)use the aux-crate directive for this purpose. This is very edge-casey so I don't think we should document this in rustc-dev-guide. If someone eneds to do this they will look at the code and easily find the functionality. This is a bit hacky since `--extern priv:pm.rs` is not valid, but we can make our directives work however we want. And I think this is a fine pragmatic balance. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future.
Enselic
force-pushed
the
proc-macro-priv
branch
from
b966c10 to
af9bd4d
Compare
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
S-waiting-on-review
Collaborator
Member
|
I feel like I’m missing a lot of context here. It’s very unclear to me what the new directive syntax is doing, or why. |
Member
Author
rustbot
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that
pub-priv1.rstest does not have to (ab)use theaux-cratedirective for this purpose. Which in turn makes it possible to make//@ no-prefer-dynamicactually not try to link dynamically. See #151257 and the test failure.This is very edge-casey so I don't think we should document this in rustc-dev-guide. If someone needs to do this they will look at the code and easily find the functionality.
This is a bit hacky since
--extern priv:pm.rsis not valid, but we can make our directives work however we want. And I think this is a fine pragmatic balance. Doing it "the right way" would be a lot of work for not much gain. Plus, that work can be done incrementally in small steps in the future if needed and wanted.Unblocks: