Skip to content

Commit b0fe733

Browse files
author
The rustc-dev-guide Cronjob Bot
committed
Merge from rustc
2 parents 46b2520 + cf1bfb3 commit b0fe733

File tree

4 files changed

+34
-11
lines changed

4 files changed

+34
-11
lines changed

src/notification-groups/about.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Here's the list of the notification groups:
2323
- [ARM](./arm.md)
2424
- [Cleanup Crew](./cleanup-crew.md)
2525
- [Emscripten](./emscripten.md)
26-
- [LLVM](./llvm.md)
26+
- [LLVM Icebreakers](./llvm.md)
2727
- [RISC-V](./risc-v.md)
2828
- [WASI](./wasi.md)
2929
- [WebAssembly](./wasm.md)
@@ -83,7 +83,7 @@ group. For example:
8383
@rustbot ping arm
8484
@rustbot ping cleanup-crew
8585
@rustbot ping emscripten
86-
@rustbot ping llvm
86+
@rustbot ping icebreakers-llvm
8787
@rustbot ping risc-v
8888
@rustbot ping wasi
8989
@rustbot ping wasm

src/notification-groups/llvm.md

+8-5
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
1-
# LLVM Notification group
1+
# LLVM Icebreakers Notification group
22

33
**Github Label:** [A-LLVM] <br>
4-
**Ping command:** `@rustbot ping llvm`
4+
**Ping command:** `@rustbot ping icebreakers-llvm`
55

66
[A-LLVM]: https://github.com/rust-lang/rust/labels/A-LLVM
77

8-
The "LLVM Notification Group" are focused on bugs that center around LLVM.
9-
These bugs often arise because of LLVM optimizations gone awry, or as
10-
the result of an LLVM upgrade. The goal here is:
8+
*Note*: this notification group is *not* the same as the LLVM working group
9+
(WG-llvm).
10+
11+
The "LLVM Icebreakers Notification Group" are focused on bugs that center around
12+
LLVM. These bugs often arise because of LLVM optimizations gone awry, or as the
13+
result of an LLVM upgrade. The goal here is:
1114

1215
- to determine whether the bug is a result of us generating invalid LLVM IR,
1316
or LLVM misoptimizing;

src/tests/ci.md

+2
Original file line numberDiff line numberDiff line change
@@ -180,6 +180,8 @@ their results can be seen [here](https://github.com/rust-lang-ci/rust/actions),
180180
although usually you will be notified of the result by a comment made by bors on
181181
the corresponding PR.
182182
183+
Note that if you start the default try job using `@bors try`, it will skip building several `dist` components and running post-optimization tests, to make the build duration shorter. If you want to execute the full build as it would happen before a merge, add an explicit `try-job` pattern with the name of the default try job (currently `dist-x86_64-linux`).
184+
183185
Multiple try builds can execute concurrently across different PRs.
184186
185187
<div class="warning">

src/tests/ui.md

+22-4
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,9 @@ several ways to match the message with the line (see the examples below):
202202
* `~|`: Associates the error level and message with the *same* line as the
203203
*previous comment*. This is more convenient than using multiple carets when
204204
there are multiple messages associated with the same line.
205+
* `~?`: Used to match error levels and messages with errors not having line
206+
information. These can be placed on any line in the test file, but are
207+
conventionally placed at the end.
205208

206209
Example:
207210

@@ -270,10 +273,23 @@ fn main() {
270273
//~| ERROR this pattern has 1 field, but the corresponding tuple struct has 3 fields [E0023]
271274
```
272275

276+
#### Error without line information
277+
278+
Use `//~?` to match an error without line information.
279+
`//~?` is precise and will not match errors if their line information is available.
280+
It should be preferred to using `error-pattern`, which is imprecise and non-exhaustive.
281+
282+
```rust,ignore
283+
//@ compile-flags: --print yyyy
284+
285+
//~? ERROR unknown print request: `yyyy`
286+
```
287+
273288
### `error-pattern`
274289

275-
The `error-pattern` [directive](directives.md) can be used for messages that don't
276-
have a specific span.
290+
The `error-pattern` [directive](directives.md) can be used for runtime messages, which don't
291+
have a specific span, or for compile time messages if imprecise matching is required due to
292+
multi-line platform specific diagnostics.
277293

278294
Let's think about this test:
279295

@@ -300,7 +316,9 @@ fn main() {
300316
}
301317
```
302318

303-
But for strict testing, try to use the `ERROR` annotation as much as possible.
319+
But for strict testing, try to use the `ERROR` annotation as much as possible,
320+
including `//~?` annotations for diagnostics without span.
321+
For compile time diagnostics `error-pattern` should very rarely be necessary.
304322

305323
### Error levels
306324

@@ -353,7 +371,7 @@ would be a `.mir.stderr` and `.thir.stderr` file with the different outputs of
353371
the different revisions.
354372

355373
> Note: cfg revisions also work inside the source code with `#[cfg]` attributes.
356-
>
374+
>
357375
> By convention, the `FALSE` cfg is used to have an always-false config.
358376
359377
## Controlling pass/fail expectations

0 commit comments

Comments
 (0)