Skip to content

Commit 09664e9

Browse files
KobzolKobzol
authored
Merge pull request #2063 from panstromek/triage
Add triage for 2025-03-31
2 parents 9c75005 + 9bd6fc2 commit 09664e9

File tree

1 file changed

+166
-0
lines changed

1 file changed

+166
-0
lines changed

Diff for: ‎triage/2025-03-31.md

+166
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,166 @@
1+
# 2025-03-31 Triage Log
2+
3+
Positive week, with a lot of primary improvements and just a few secondary regressions. Single big regression got reverted.
4+
5+
Triage done by **@panstromek**.
6+
Revision range: [4510e86a..2ea33b59](https://perf.rust-lang.org/?start=4510e86a41388733675465a8647d4235f3bf2023&end=2ea33b591050c4ca1a3752830b29112638faecf6&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | - | - | 0 |
13+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.2%, 1.5%] | 17 |
14+
| Improvements ✅ <br /> (primary) | -0.4% | [-4.5%, -0.1%] | 136 |
15+
| Improvements ✅ <br /> (secondary) | -0.6% | [-3.2%, -0.1%] | 59 |
16+
| All ❌✅ (primary) | -0.4% | [-4.5%, -0.1%] | 136 |
17+
18+
19+
1 Regression, 6 Improvements, 4 Mixed; 3 of them in rollups
20+
39 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
perform less decoding if it has the same syntax context [#129827](https://github.com/rust-lang/rust/pull/129827) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5cc60728e7ee10eb2ae5f61f7d412d9805b22f0c&end=d4812c8638173ec163825d56a72a33589483ec4c&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:-----:|:--------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.9% | [0.1%, 3.8%] | 77 |
29+
| Regressions ❌ <br /> (secondary) | 2.3% | [0.2%, 6.1%] | 37 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
32+
| All ❌✅ (primary) | 0.9% | [0.1%, 3.8%] | 77 |
33+
34+
Reverted in #[139130](https://github.com/rust-lang/rust/pull/139130).
35+
36+
#### Improvements
37+
38+
rustdoc: Rearrange `Item`/`ItemInner`. [#138927](https://github.com/rust-lang/rust/pull/138927) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ecb170afc878648c3ae355dbd596c8e4b6f7ebdc&end=217693a1f02ca6431a434926ff3417bdb6dbac2e&stat=instructions:u)
39+
40+
| (instructions:u) | mean | range | count |
41+
|:----------------------------------:|:-----:|:--------------:|:-----:|
42+
| Regressions ❌ <br /> (primary) | - | - | 0 |
43+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
44+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 2 |
45+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
46+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.3%] | 2 |
47+
48+
49+
Rollup of 7 pull requests [#139023](https://github.com/rust-lang/rust/pull/139023) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=217693a1f02ca6431a434926ff3417bdb6dbac2e&end=3f5502370b8f60e4df98deba4c22ea26f4f6be55&stat=instructions:u)
50+
51+
| (instructions:u) | mean | range | count |
52+
|:----------------------------------:|:-----:|:--------------:|:-----:|
53+
| Regressions ❌ <br /> (primary) | - | - | 0 |
54+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
55+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.5%, -0.2%] | 21 |
56+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.2%] | 1 |
57+
| All ❌✅ (primary) | -0.4% | [-0.5%, -0.2%] | 21 |
58+
59+
60+
Avoid wrapping constant allocations in packed structs when not necessary [#138503](https://github.com/rust-lang/rust/pull/138503) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e77a8f439cc87c5d67b007e9811578533de1de91&end=2a06022951893fe5b5384f8dbd75b4e6e3b5cee0&stat=instructions:u)
61+
62+
| (instructions:u) | mean | range | count |
63+
|:----------------------------------:|:-----:|:--------------:|:-----:|
64+
| Regressions ❌ <br /> (primary) | - | - | 0 |
65+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
66+
| Improvements ✅ <br /> (primary) | -1.6% | [-4.9%, -0.3%] | 6 |
67+
| Improvements ✅ <br /> (secondary) | -2.0% | [-3.3%, -0.3%] | 9 |
68+
| All ❌✅ (primary) | -1.6% | [-4.9%, -0.3%] | 6 |
69+
70+
71+
Rollup of 7 pull requests [#139054](https://github.com/rust-lang/rust/pull/139054) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=2a06022951893fe5b5384f8dbd75b4e6e3b5cee0&end=19f42cb9bb65555e7d95dab7d17573ae6c5d634c&stat=instructions:u)
72+
73+
| (instructions:u) | mean | range | count |
74+
|:----------------------------------:|:-----:|:--------------:|:-----:|
75+
| Regressions ❌ <br /> (primary) | - | - | 0 |
76+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
77+
| Improvements ✅ <br /> (primary) | - | - | 0 |
78+
| Improvements ✅ <br /> (secondary) | -0.4% | [-2.2%, -0.1%] | 9 |
79+
| All ❌✅ (primary) | - | - | 0 |
80+
81+
82+
Remove `terminating_scopes` hash set. [#139067](https://github.com/rust-lang/rust/pull/139067) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=928468c47c2a670bfa62727cfa2f14f75f5b7331&end=898916595c4496cee237a82f3f07650e5bd70447&stat=instructions:u)
83+
84+
| (instructions:u) | mean | range | count |
85+
|:----------------------------------:|:-----:|:--------------:|:-----:|
86+
| Regressions ❌ <br /> (primary) | - | - | 0 |
87+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
88+
| Improvements ✅ <br /> (primary) | -0.1% | [-0.1%, -0.1%] | 1 |
89+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.2%, -0.1%] | 9 |
90+
| All ❌✅ (primary) | -0.1% | [-0.1%, -0.1%] | 1 |
91+
92+
93+
Revert "Auto merge of #129827 - bvanjoi:less-decoding, r=petrochenkov" [#139130](https://github.com/rust-lang/rust/pull/139130) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b9ea82b84ad02b4a9fe9e513626e65fb3f540838&end=45b40a75966b36d3588f173441896fddad01cd80&stat=instructions:u)
94+
95+
| (instructions:u) | mean | range | count |
96+
|:----------------------------------:|:-----:|:--------------:|:-----:|
97+
| Regressions ❌ <br /> (primary) | - | - | 0 |
98+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.4%, 0.6%] | 2 |
99+
| Improvements ✅ <br /> (primary) | -0.9% | [-3.6%, -0.1%] | 74 |
100+
| Improvements ✅ <br /> (secondary) | -2.2% | [-5.7%, -0.2%] | 37 |
101+
| All ❌✅ (primary) | -0.9% | [-3.6%, -0.1%] | 74 |
102+
103+
Addresses the regression above.
104+
105+
#### Mixed
106+
107+
Rollup of 9 pull requests [#138923](https://github.com/rust-lang/rust/pull/138923) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7d49ae9731555937177d01e9fa39dbf22eb60399&end=48994b1674b3212d27b5e83841c0966bc2b4be43&stat=instructions:u)
108+
109+
| (instructions:u) | mean | range | count |
110+
|:----------------------------------:|:-----:|:--------------:|:-----:|
111+
| Regressions ❌ <br /> (primary) | - | - | 0 |
112+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.2%, 1.4%] | 14 |
113+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.6%, -0.6%] | 1 |
114+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.6%, -0.2%] | 10 |
115+
| All ❌✅ (primary) | -0.6% | [-0.6%, -0.6%] | 1 |
116+
117+
Regressions for `unused-warnings`, seems to be somewhere in the frontend (check build regressed the most).
118+
119+
Seems like it's [#138580](https://github.com/rust-lang/rust/pull/138580).
120+
121+
Quoting [comment from the author](https://github.com/rust-lang/rust/pull/138580#issuecomment-2729429154)
122+
123+
> Probably fine, unused-warnings is a stress test for single_imports.
124+
125+
Part of it is probably continuation of that PR in [#138837](https://github.com/rust-lang/rust/pull/138837)
126+
127+
128+
hygiene: Ensure uniqueness of `SyntaxContextData`s [#130324](https://github.com/rust-lang/rust/pull/130324) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f1bc669636023c8643602431791c7f26e5a6edef&end=19cab6b878ab18dce4816d85ac52b317214c485f&stat=instructions:u)
129+
130+
| (instructions:u) | mean | range | count |
131+
|:----------------------------------:|:-----:|:--------------:|:-----:|
132+
| Regressions ❌ <br /> (primary) | - | - | 0 |
133+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.1%, 0.2%] | 2 |
134+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.7%, -0.2%] | 30 |
135+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.5%, -0.5%] | 3 |
136+
| All ❌✅ (primary) | -0.4% | [-0.7%, -0.2%] | 30 |
137+
138+
Improvements outweigh regressions. Regression `tt-muncher` seems spurious (the benchmark got back to previous state in a following rollup). `deep-vector` looks like noise.
139+
140+
141+
Remove `prev_index_to_index` field from `CurrentDepGraph` [#138824](https://github.com/rust-lang/rust/pull/138824) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=19cab6b878ab18dce4816d85ac52b317214c485f&end=a2e63569fd6702ac5dd027a80a9fdaadce73adae&stat=instructions:u)
142+
143+
| (instructions:u) | mean | range | count |
144+
|:----------------------------------:|:-----:|:--------------:|:-----:|
145+
| Regressions ❌ <br /> (primary) | - | - | 0 |
146+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.4%] | 3 |
147+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 30 |
148+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 3 |
149+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 30 |
150+
151+
Instruction count improvements outweigh regressions. Regression in `unused-warnings` looks real, but small.
152+
153+
There's a somewhat large `max-rss` and `wall-time` regression in small incremental scenarios.
154+
155+
156+
Simplify expansion for format_args!(). [#139131](https://github.com/rust-lang/rust/pull/139131) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fedf10752b973d83f3f7c0f819b2659c21a634de&end=2ea33b591050c4ca1a3752830b29112638faecf6&stat=instructions:u)
157+
158+
| (instructions:u) | mean | range | count |
159+
|:----------------------------------:|:-----:|:--------------:|:-----:|
160+
| Regressions ❌ <br /> (primary) | - | - | 0 |
161+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 1 |
162+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.8%, -0.2%] | 8 |
163+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 1 |
164+
| All ❌✅ (primary) | -0.5% | [-0.8%, -0.2%] | 8 |
165+
166+
[Pre-merge results](https://github.com/rust-lang/rust/pull/139131#issuecomment-2764550579) look better than post-merge. Single regression in `tt-muncher` looks like noise.

0 commit comments

Comments
 (0)