Skip to content

Change to attr format? #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smoelius opened this issue Mar 10, 2025 · 5 comments
Closed

Change to attr format? #48

smoelius opened this issue Mar 10, 2025 · 5 comments

Comments

@smoelius
Copy link

In JSON produced by recent versions of rustdoc-types, the attrs look like this:

"#[attr=\"Stability{stability: Stability{level: Unstable{reason: Noneissue:\n127154is_soft: falseimplied_by: }feature: anonymous_pipe}span: }\")]\n"

I think they used to more closely resemble what appears in the source code:

"#[unstable(feature = \"anonymous_pipe\", issue = \"127154\")]"

Can I just confirm the change is intentional?

Not to nit, but the falseimplied_by as one word looks suspicious.

@Enselic
Copy link
Member

Enselic commented Mar 10, 2025

See rust-lang/rust#137645

Edit to avoid notifying others: Yes.

@smoelius
Copy link
Author

Thanks, @Enselic. To be sure I understand, this is an active topic of discussion? Is that the right conclusion?

@aDotInTheVoid
Copy link
Member

Can I just confirm the change is intentional?

Yep! See https://github.com/rust-lang/rustdoc-types/blob/trunk/CHANGELOG.md#v0.36.0

this is an active topic of discussion? Is that the right conclusion?

Also yep! See rust-lang/rust#137645 and https://github.com/rust-lang/rust/pull/138063/files#r1981637128 for example

@aDotInTheVoid
Copy link
Member

I'm gonna close this as not being a question/tracked elsewhere.

@aDotInTheVoid aDotInTheVoid closed this as not planned Won't fix, can't repro, duplicate, stale Mar 10, 2025
@smoelius
Copy link
Author

Thanks, @aDotInTheVoid. I should have thought to check the changelog. 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants