Skip to content

Custom list tweaks #4351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged

Custom list tweaks #4351

merged 3 commits into from
May 30, 2025

Conversation

djc
Copy link
Contributor

@djc djc commented May 30, 2025

Follow up on #4347.

cc @FranciscoTGouveia

@djc djc requested review from ChrisDenton and rami3l May 30, 2025 15:23
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the improvements!

@djc djc force-pushed the custom-list-tweaks branch from ae832e0 to c361122 Compare May 30, 2025 18:39
djc added 3 commits May 30, 2025 20:39
Use the first line as a high-level description. Separate the explanation
of the `items` argument type, and drop a stray '"' character.
@djc djc force-pushed the custom-list-tweaks branch from c361122 to 9606e94 Compare May 30, 2025 18:40
@djc djc enabled auto-merge May 30, 2025 18:40
@djc djc added this pull request to the merge queue May 30, 2025
Merged via the queue into master with commit 02c34f3 May 30, 2025
29 checks passed
@djc djc deleted the custom-list-tweaks branch May 30, 2025 19:34
@FranciscoTGouveia
Copy link
Contributor

FranciscoTGouveia commented May 31, 2025

Hello @djc!
Thank you for this PR, and apologies for not thinking of this earlier.
You're absolutely right, this approach is much cleaner.
I'll do my best to avoid situations like this in future contributions :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants