From 6f5306db252db650f321fd0e547aaafac5705428 Mon Sep 17 00:00:00 2001 From: Eric Holk Date: Thu, 26 Aug 2021 16:32:33 -0700 Subject: [PATCH 1/3] Refine polish section impact, define milestones This change elaborates the desired impact from the polish area and also sets an initial set of milestones to bring about this impact. We will continue to refine these over time. --- src/vision/roadmap/polish.md | 35 ++++++++++++++++++++++++++++++++--- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/src/vision/roadmap/polish.md b/src/vision/roadmap/polish.md index 98282b53..0c9a483e 100644 --- a/src/vision/roadmap/polish.md +++ b/src/vision/roadmap/polish.md @@ -2,7 +2,36 @@ ## Impact +* Users can predict and understand why the compiler raises error messages. Errors are aligned with an experienced user's intuition about how Rust works. +* Error messages identify common misconceptions, suggest solutions, and are generally on par with sync Rust. + * Errors not only show that there is a problem, they help the user to fix it and to learn more about Rust (possibly directing the user to other documentation). + * The compiler may suggest crates from the ecosystem to help solve problems when appropriate. * Lints guide the user away from common errors and help them both to get started with async Rust and to maintain async Rust programs over time. -* Errors not only show that there is a problem, they help the user to fix it and to learn more about Rust (possibly directing the user to other documentation). -* The generated code from the compiler is high quality and performant. -* Integration with low-level tooling and the like is high-quality. \ No newline at end of file +* Rust's async implementation is high quality and reflects an attention to detail. + * No internal compiler errors + * Compiler analysis and code generation passes are precise and not unnecessarily conservative. + * Integration with low-level tooling and the like is high-quality. + * The generated code from the compiler is high quality and performant. + +## Milestones + +| Milestone | State | Key participants | +| --- | --- | --- | +| Precise generator captures | 🦀 | [eholk] | +| ↳ Prototype | 🦀 | [eholk] | +| ↳ Documented in Rust Reference | 🦀 | [eholk] | +| ↳ [Lang team] signoff | 💤 | [Lang team] | +| ↳ Stabilized | 💤 | [eholk] | +| Lint: [Large copies], large generators | 💤 | | +| ↳ [Lang team] initiative proposal | 💤 | | +| ↳ Implementation | 💤 | | +| Lint: [Live over yield] | 💤 | | +| ↳ Landed the RFC | 💤 | | +| Lint: [Blocking in async context] | 💤 | | + + +[eholk]: https://github.com/eholk/ +[Lang team]: https://www.rust-lang.org/governance/teams/lang +[Blocking in async context]: ./polish/lint_blocking_fns.md +[Large copies]: ./polish/lint_large_copies.md +[Live over yield]: ./polish/lint_must_not_suspend.md From 1f48014a86aa3933112ec086964bc4b3537a7ee5 Mon Sep 17 00:00:00 2001 From: Eric Holk Date: Fri, 27 Aug 2021 14:43:25 -0700 Subject: [PATCH 2/3] Link to 'must not suspend' lint RFC --- src/vision/roadmap/polish.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/vision/roadmap/polish.md b/src/vision/roadmap/polish.md index 0c9a483e..39f01b39 100644 --- a/src/vision/roadmap/polish.md +++ b/src/vision/roadmap/polish.md @@ -25,8 +25,8 @@ | Lint: [Large copies], large generators | 💤 | | | ↳ [Lang team] initiative proposal | 💤 | | | ↳ Implementation | 💤 | | -| Lint: [Live over yield] | 💤 | | -| ↳ Landed the RFC | 💤 | | +| Lint: [Must not suspend] | 💤 | | +| ↳ Landed the [RFC] | 💤 | | | Lint: [Blocking in async context] | 💤 | | @@ -34,4 +34,5 @@ [Lang team]: https://www.rust-lang.org/governance/teams/lang [Blocking in async context]: ./polish/lint_blocking_fns.md [Large copies]: ./polish/lint_large_copies.md -[Live over yield]: ./polish/lint_must_not_suspend.md +[Must not suspend]: ./polish/lint_must_not_suspend.md +[RFC]: https://rust-lang.github.io/rfcs/3014-must-not-suspend-lint.html From 526baebd134ed8c00565bee0fc18cf18971c1726 Mon Sep 17 00:00:00 2001 From: Eric Holk Date: Mon, 30 Aug 2021 09:09:54 -0700 Subject: [PATCH 3/3] Code review feedback --- src/vision/roadmap/polish.md | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/vision/roadmap/polish.md b/src/vision/roadmap/polish.md index 39f01b39..2a38ac26 100644 --- a/src/vision/roadmap/polish.md +++ b/src/vision/roadmap/polish.md @@ -18,16 +18,19 @@ | Milestone | State | Key participants | | --- | --- | --- | | Precise generator captures | 🦀 | [eholk] | -| ↳ Prototype | 🦀 | [eholk] | +| ↳ Prototyped | 🦀 | [eholk] | | ↳ Documented in Rust Reference | 🦀 | [eholk] | +| ↳ [Lang team] initiative proposal | 💤 | [eholk] | | ↳ [Lang team] signoff | 💤 | [Lang team] | | ↳ Stabilized | 💤 | [eholk] | | Lint: [Large copies], large generators | 💤 | | | ↳ [Lang team] initiative proposal | 💤 | | -| ↳ Implementation | 💤 | | +| ↳ Implementated | 💤 | | | Lint: [Must not suspend] | 💤 | | -| ↳ Landed the [RFC] | 💤 | | +| ↳ Implemented the [RFC] | 💤 | | | Lint: [Blocking in async context] | 💤 | | +| ↳ RFC proposed and accepted | 💤 | | +| ↳ Implementated | 💤 | | [eholk]: https://github.com/eholk/