feat: proxy ptty sequences to device

Extends the ptty integration so that code running on the device can
query the host-side ptty's cursor position (& "Keyboard Enhancement
Flags"), which is required for `noline`[^1] to function.

See also: rustbox/crossterm@1d223fd

[^1]: a rust crate that implements a `no_std` readline clone

Author: sethp

Cargo.lock

@@ -33,7 +33,9 @@ clap = { version = "4.5.4", features = [
 ], optional = true }
 clap_complete = { version = "4.5.2", optional = true }
 comfy-table = { version = "7.1.1", optional = true }
-crossterm = { version = "0.25.0", optional = true } # 0.26.x and 0.27.x causes issues on Windows
+crossterm = { git = "https://github.com/rustbox/crossterm", rev = "1d223fd2bca8b7df795d4f047ad54f7b39edbdbd", optional = true, features = [
+    "unfiltered-events",
+] } # 0.26.x and 0.27.x causes issues on Windows
 ctrlc = { version = "3.4.4", optional = true }
 # defmt dependencies are pinned since defmt does not guarantee MSRV even for patch releases
 defmt-decoder = { version = "0.3.11", features = [

espflash/Cargo.toml

@@ -91,7 +91,7 @@ pub fn monitor(
         .into_diagnostic()?;
 
     // We are in raw mode until `_raw_mode` is dropped (ie. this function returns).
-    let _raw_mode = RawModeGuard::new();
+    let _raw_mode = RawModeGuard::new()?;
 
     let stdout = stdout();
     let mut stdout = ResolvingPrinter::new(elf, stdout.lock());
@@ -116,24 +116,31 @@ pub fn monitor(
         stdout.flush().ok();
 
         if interactive_mode && poll(Duration::from_secs(0)).into_diagnostic()? {
-            if let Event::Key(key) = read().into_diagnostic()? {
-                if key.kind == KeyEventKind::Press {
-                    if key.modifiers.contains(KeyModifiers::CONTROL) {
-                        match key.code {
-                            KeyCode::Char('c') => break,
-                            KeyCode::Char('r') => {
-                                reset_after_flash(&mut serial, pid).into_diagnostic()?;
-                                continue;
+            match read().into_diagnostic()? {
+                Event::Key(key) => {
+                    if key.kind == KeyEventKind::Press {
+                        if key.modifiers.contains(KeyModifiers::CONTROL) {
+                            match key.code {
+                                KeyCode::Char('c') => break,
+                                KeyCode::Char('r') => {
+                                    reset_after_flash(&mut serial, pid).into_diagnostic()?;
+                                    continue;
+                                }
+                                _ => {}
                             }
-                            _ => {}
                         }
-                    }
 
-                    if let Some(bytes) = handle_key_event(key) {
-                        serial.write_all(&bytes).into_diagnostic()?;
-                        serial.flush().into_diagnostic()?;
+                        if let Some(bytes) = handle_key_event(key) {
+                            serial.write_all(&bytes).into_diagnostic()?;
+                            serial.flush().into_diagnostic()?;
+                        }
                     }
                 }
+                Event::Raw(bytes) => {
+                    serial.write_all(&bytes).into_diagnostic()?;
+                    serial.flush().into_diagnostic()?
+                }
+                _ => {}
             }
         }
     }