Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert output string parsing to detect broken replication #395

Open
rustprooflabs opened this issue Jul 6, 2024 · 1 comment
Open

Revert output string parsing to detect broken replication #395

rustprooflabs opened this issue Jul 6, 2024 · 1 comment
Labels
external External project or constraint. Blocked, related or otherwise Technical Debt Not broken, not new, but not right either!

Comments

@rustprooflabs
Copy link
Owner

Details

The approach I took in #392 to fix #391 was a result of getting an invalid returncode=0 when there was an error.

Hoping that osm2pgsql-dev/osm2pgsql#2206 can lead to getting the returncode set properly. If it does, the line parsing for specific error text can be removed.
@rustprooflabs rustprooflabs added external External project or constraint. Blocked, related or otherwise Technical Debt Not broken, not new, but not right either! labels Jul 6, 2024
@rustprooflabs rustprooflabs changed the title Revert line parsing to detect broken replication Revert output string parsing to detect broken replication Jul 6, 2024
@rustprooflabs
Copy link
Owner Author

This one will be ready to work on after osmcode/pyosmium#257 is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external External project or constraint. Blocked, related or otherwise Technical Debt Not broken, not new, but not right either!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rustprooflabs