Take alignment into consideration during malloc
#3463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
alloc-align
branch
2 times, most recently
from
b2afed6 to
da0cf24
Compare
Liamolucko
reviewed
Jun 6, 2023
Contributor
Liamolucko
left a comment
Liamolucko
left a comment
There was a problem hiding this comment.
Looks good for the most part!
Liamolucko
reviewed
Jun 6, 2023
daxpedda
commented
Jun 6, 2023
daxpedda
commented
Jun 6, 2023
Co-Authored-By: Liam Murphy <[email protected]>
daxpedda
commented
Jun 6, 2023
Co-Authored-By: Liam Murphy <[email protected]>
Liamolucko
reviewed
Jun 6, 2023
Liamolucko
approved these changes
Jun 6, 2023
Contributor
Liamolucko
left a comment
Liamolucko
left a comment
There was a problem hiding this comment.
This is pretty much good to merge, I just noticed that the bit of the guide you updated is still using an alignment of 4 for strings.
Co-Authored-By: Liam Murphy <[email protected]>
daxpedda
force-pushed
the
alloc-align
branch
2 times, most recently
from
28b3c12 to
750eccc
Compare
1 task
Wumpf
pushed a commit
to rerun-io/rerun
that referenced
this pull request
Jun 13, 2023
It contains this important fix for Rust 1.70: wasm-bindgen/wasm-bindgen#3463 I tested the web viewer, and it works. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2406 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/eebb149/docs Examples preview: https://rerun.io/preview/eebb149/examples <!-- pr-link-docs:end -->
emilk
added a commit
to rerun-io/rerun
that referenced
this pull request
Jun 15, 2023
It contains this important fix for Rust 1.70: wasm-bindgen/wasm-bindgen#3463 I tested the web viewer, and it works. ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2406 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/eebb149/docs Examples preview: https://rerun.io/preview/eebb149/examples <!-- pr-link-docs:end -->
crapStone
added a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jun 29, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [js-sys](https://rustwasm.github.io/wasm-bindgen/) ([source](https://github.com/rustwasm/wasm-bindgen)) | dependencies | patch | `=0.3.63` -> `=0.3.64` | | [wasm-bindgen](https://rustwasm.github.io/) ([source](https://github.com/rustwasm/wasm-bindgen)) | dependencies | patch | `=0.2.86` -> `=0.2.87` | | [wasm-bindgen-futures](https://rustwasm.github.io/wasm-bindgen/) ([source](https://github.com/rustwasm/wasm-bindgen)) | dependencies | patch | `=0.4.36` -> `=0.4.37` | --- ### Release Notes <details> <summary>rustwasm/wasm-bindgen (wasm-bindgen)</summary> ### [`v0.2.87`](https://github.com/rustwasm/wasm-bindgen/blob/HEAD/CHANGELOG.md#​0287-httpsgithubcomrustwasmwasm-bindgencompare02860287) [Compare Source](wasm-bindgen/wasm-bindgen@0.2.86...0.2.87) Released 2023-06-12. ##### Added - Implemented `IntoIterator` for `Array`. [#​3477](wasm-bindgen/wasm-bindgen#3477) ##### Changed - Deprecate `HtmlMenuItemElement` and parts of `HtmlMenuElement`. [#​3448](wasm-bindgen/wasm-bindgen#3448) - Stabilize `ResizeObserver`. [#​3459](wasm-bindgen/wasm-bindgen#3459) ##### Fixed - Take alignment into consideration during (de/re)allocation. [#​3463](wasm-bindgen/wasm-bindgen#3463) *** </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNDQuMyIsInVwZGF0ZWRJblZlciI6IjM1LjE0NC4zIiwidGFyZ2V0QnJhbmNoIjoiZGV2ZWxvcCJ9--> Co-authored-by: cabr2-bot <[email protected]> Co-authored-by: crapStone <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1947 Reviewed-by: crapStone <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
This was referenced Oct 3, 2023
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I had to hardcode an alignment of 4 because we didn't implement something to detect the target architecture when using
wasm-bindgen-cli.This is still missing adjustments on__wbindgen_reallocand__wbindgen_free.This is fairly hacky, unfortunately I simply don't know enough about the
wasm-bindgencodebase. Feel free to suggest how it could be done right.Fixes #3461.