Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install hook may fail if there is already a stream block #1

Open
josegonzalez opened this issue Jun 26, 2020 · 3 comments
Open

Install hook may fail if there is already a stream block #1

josegonzalez opened this issue Jun 26, 2020 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@josegonzalez
Copy link

Not sure how we might detect an existing stream block, but thats one potential issue.

@rvanlaar
Copy link
Owner

Noted. Ran into this problem when testing.

Regular nginx configurations don't seem to include a stream block.

@josegonzalez
Copy link
Author

Yep thats correct. My gut says that you can regex find an uncommented stream block in the conf and then add it if it isn't there.

This library could be used to parse the conf files, but dunno how strict/not strict it needs to be.

@rvanlaar
Copy link
Owner

rvanlaar commented Jul 3, 2020

I'm rating this as a low priority issue. I've yet to see a default config that includes a stream directive.
When that happens, I'll be happy to work with those affected to include a fix.

@rvanlaar rvanlaar added the help wanted Extra attention is needed label Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants