Skip to content

Batch Norm should have in_dim #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albertz opened this issue Jan 3, 2022 · 0 comments
Closed

Batch Norm should have in_dim #889

albertz opened this issue Jan 3, 2022 · 0 comments

Comments

@albertz
Copy link
Member

albertz commented Jan 3, 2022

We need to know the dimensions which should be reduced to gather the statistics.

It would reduce over batch dim and spatial dims (in_spatial_dims).

Or, we specify the dims which it should not reduce, e.g. in_dim.

Or in_dims but that is not supported currently. Note that while conceptually the order of in_dims does not matter, it matters for the definition of the parameter. So it must be a sequence in case of multiple dims. Also, in_spatial_dims would not be enough as it would not define the order of in_dims. So that implies that specifying in_dims makes more sense than in_spatial_dims.

But anyway, maybe in_dim makes most sense for now.

Like #597. Or like #789 for ConvLayer.

@albertz albertz changed the title Batch Norm should have in_spatial_dim option. Or maybe in_dim or in_dims Batch Norm should have in_dim or in_dims Jan 3, 2022
@albertz albertz changed the title Batch Norm should have in_dim or in_dims Batch Norm should have in_dim Jan 5, 2022
@albertz albertz closed this as completed in ea76d37 Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant