Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of adding lume.deepclone #29

Open
Greyvy opened this issue Mar 8, 2019 · 0 comments
Open

Possibility of adding lume.deepclone #29

Greyvy opened this issue Mar 8, 2019 · 0 comments

Comments

@Greyvy
Copy link

Greyvy commented Mar 8, 2019

Hey there,

Not sure if you’re still working on this repo at all or what, but I figured I would give it a shot. I’ve been using lume on a small game I’ve been working on, very handy little library, big fan so far.

I ran into a case where I needed to make a simple clone of a table, and the lume.clone out of the box only does sub tables by reference, which was a bit of an issue in the code I was working on.

After doing a little bit of research I found a couple of very sane ways of doing a bit more thorough cloning. If you are up for having a deepclone, or even just replacing the current lume.clone, I would be happy to shoot you a pull request.

Let me know what you think, and thanks again for the excellent library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant