lume.format(str, table) doesn't properly handle false values

[wolf81]

Simple test:

local t = lume.format("{1} is {2} is {3}", { true, false, true })
print(t) -- true is {2} is true

I guess this is of the way Lua deals with false values, not sure what a proper fix would be, but if I can figure one out I will send a PR.

[NQMVD]

I know it's an old Issue but i fixed it on my fork by modifying the f function like so:

local f = function(x)
  local index = tonumber(x)
  if index then
    return tostring(vars[index])
  else
    return tostring(vars[x])
  end
end

and it works now:

print(lume.format("{1} is {2} and {f}", {true, false, f=false}))
-- prints true is false and false

it just prints nil in case of 'not found' now

[wolfgang-ironsoftware]

@ItsNMB Very nice if it works - I hope to check it in the couple of weeks. I still use Lua/LOVE/lume in hobby projects, so if your fix works, it will be useful to me :)

And maybe your approach gave me an idea for an even cleaner fix ... hmm..

[wolf81]

@ITSN

I know it's an old Issue but i fixed it on my fork by modifying the f function like so:

local f = function(x)
  local index = tonumber(x)
  if index then
    return tostring(vars[index])
  else
    return tostring(vars[x])
  end
end

and it works now:

print(lume.format("{1} is {2} and {f}", {true, false, f=false}))
-- prints true is false and false

it just prints nil in case of 'not found' now

Hi, it's been a long time to verify and respond and yes, your approach fixes the issues with booleans.

It makes 3 tests fail though. Maybe the tests should be adjusted.

I'll probably use your approach in my fork as well, after I've fixed tests.