forked from pinterest/gestalt
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Masonry experiments warning (pinterest#374)
* wip * remove canary
- Loading branch information
1 parent
67a19db
commit 99d3ac7
Showing
4 changed files
with
22 additions
and
0 deletions.
There are no files selected for viewing
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
## TODO | ||
|
||
- [ ] Documentation | ||
- [ ] Tests | ||
- [ ] Experimental evidence (required for Masonry changes) | ||
- [ ] Accessibility checkup |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
// @flow | ||
|
||
export default function experiments() { | ||
const changed = danger.git.modified_files.some(file => | ||
file.match(/masonry/i) | ||
); | ||
if (changed) { | ||
const title = ':microscope: Experimental data needed'; | ||
const message = | ||
'Changes were made to critical components. Do you have experimental data to back up your changes?'; | ||
warn(`${title} - <i>${message}</i>`); | ||
} | ||
} |