fix: various notice fixes (RSS-Bridge#3718)

Author: dvikan

bridges/CodebergBridge.php

@@ -260,7 +260,11 @@ private function extractIssueComments($html)
             }
 
             $item['author'] = $div->find('a.author', 0)->innertext;
-            $item['timestamp'] = $div->find('span.time-since', 0)->title;
+
+            $timeSince = $div->find('span.time-since', 0);
+            if ($timeSince) {
+                $item['timestamp'] = $timeSince->title;
+            }
 
             $this->items[] = $item;
         }

bridges/CssSelectorComplexBridge.php

@@ -415,10 +415,14 @@ protected function parseEntryElement(
     ) {
         $article_content = convertLazyLoading($entry_html);
 
+        $article_title = '';
         if (is_null($title_selector)) {
             $article_title = $title_default;
         } else {
-            $article_title = trim($entry_html->find($title_selector, 0)->innertext);
+            $titleElement = $entry_html->find($title_selector, 0);
+            if ($titleElement) {
+                $article_title = trim($titleElement->innertext);
+            }
         }
 
         $author = null;

bridges/ImgsedBridge.php

@@ -244,7 +244,7 @@ public function getName()
             if ($this->getInput('tagged')) {
                 $types[] = 'Tags';
             }
-            $typesText = $types[0];
+            $typesText = $types[0] ?? '';
             if (count($types) > 1) {
                 for ($i = 1; $i < count($types) - 1; $i++) {
                     $typesText .= ', ' . $types[$i];

bridges/PepperBridgeAbstract.php

@@ -463,7 +463,7 @@ private function getImage($deal)
                 )
             )->{'src'};
         } else {
-            return $deal->find('img[class*=' . $selectorPlain . ']', 0)->src;
+            return $deal->find('img[class*=' . $selectorPlain . ']', 0)->src ?? '';
         }
     }
 

bridges/ThePirateBayBridge.php

@@ -65,6 +65,7 @@ class ThePirateBayBridge extends BridgeAbstract
         '207' => 'HD Movies',
         '208' => 'HD TV-Shows',
         '209' => '3D',
+        '210' => 'CAM/TS',
         '211' => 'UHD/4k Movies',
         '212' => 'UHD/4k TV-Shows',
         '299' => 'Other',

tests/UtilsTest.php

@@ -46,4 +46,14 @@ public function testCreateRandomString()
         $this->assertSame(4, strlen(create_random_string(2)));
         $this->assertSame(6, strlen(create_random_string(3)));
     }
+
+    public function testUrljoin()
+    {
+        $base = '/';
+        $rel = 'https://example.com/foo';
+
+        $url = urljoin($base, $rel);
+
+        $this->assertSame($rel, $url);
+    }
 }

vendor/php-urljoin/src/urljoin.php

@@ -40,7 +40,10 @@ function urljoin($base, $rel) {
 	}
 
 	if (isset($prel['scheme'])) {
-		if ($prel['scheme'] != $pbase['scheme'] || in_array($prel['scheme'], $uses_relative) == false) {
+		if (
+			$prel['scheme'] != ($pbase['scheme'] ?? null)
+			|| in_array($prel['scheme'], $uses_relative) == false
+		) {
 			return $rel;
 		}
 	}