refactor: FeedExpander (RSS-Bridge#3740)

* refactor: FeedExpander

Author: dvikan

bridges/CssSelectorFeedExpanderBridge.php

@@ -61,6 +61,10 @@ public function collectData()
         $discard_thumbnail = $this->getInput('discard_thumbnail');
         $limit = $this->getInput('limit');
 
+        //$xmlString = getContents($url);
+        //$feed = (new FeedParser())->parseFeed($xmlString);
+        //$items = $feed['items'];
+
         $feed_expander = new CssSelectorFeedExpanderBridgeInternal();
         $items = $feed_expander->collectExpandableDatas($url)->getItems();
 

bridges/FeedExpanderExampleBridge.php

@@ -46,21 +46,6 @@ public function collectData()
 
     protected function parseItem($newsItem)
     {
-        switch ($this->getInput('version')) {
-            case 'rss_0_9_1':
-                return $this->parseRss091Item($newsItem);
-                break;
-            case 'rss_1_0':
-                return $this->parseRss1Item($newsItem);
-                break;
-            case 'rss_2_0':
-                return $this->parseRss2Item($newsItem);
-                break;
-            case 'atom_1_0':
-                return $this->parseATOMItem($newsItem);
-                break;
-            default:
-                returnClientError('Unknown version ' . $this->getInput('version') . '!');
-        }
+        return (array) $newsItem;
     }
 }

bridges/MastodonBridge.php

@@ -82,14 +82,14 @@ public function collectData()
         }
         $items = $content['orderedItems'] ?? $content['items'];
         foreach ($items as $status) {
-            $item = $this->parseItem($status);
+            $item = $this->parseStatus($status);
             if ($item) {
                 $this->items[] = $item;
             }
         }
     }
 
-    protected function parseItem($content)
+    protected function parseStatus($content)
     {
         $item = [];
         switch ($content['type']) {

bridges/NyaaTorrentsBridge.php

@@ -67,7 +67,7 @@ public function collectData()
 
     protected function parseItem($newItem)
     {
-        $item = parent::parseRss2Item($newItem);
+        $item = parent::parseItem($newItem);
         $item['id'] = str_replace(['https://nyaa.si/download/', '.torrent'], '', $item['uri']);
 
         $nyaaFields = (array)($newItem->children('nyaa', true));

bridges/RaceDepartmentBridge.php

@@ -14,7 +14,7 @@ public function collectData()
 
     protected function parseItem($feedItem)
     {
-        $item = parent::parseRss2Item($feedItem);
+        $item = parent::parseItem($feedItem);
 
         //fetch page
         $articlePage = getSimpleHTMLDOMCached($feedItem->link);

index.php

@@ -6,6 +6,56 @@
 
 require_once __DIR__ . '/lib/bootstrap.php';
 
+Configuration::verifyInstallation();
+$customConfig = [];
+if (file_exists(__DIR__ . '/config.ini.php')) {
+    $customConfig = parse_ini_file(__DIR__ . '/config.ini.php', true, INI_SCANNER_TYPED);
+}
+Configuration::loadConfiguration($customConfig, getenv());
+
+// Consider: ini_set('error_reporting', E_ALL & ~E_DEPRECATED);
+date_default_timezone_set(Configuration::getConfig('system', 'timezone'));
+
 $rssBridge = new RssBridge();
 
+set_exception_handler(function (\Throwable $e) {
+    http_response_code(500);
+    print render(__DIR__ . '/templates/exception.html.php', ['e' => $e]);
+    RssBridge::getLogger()->error('Uncaught Exception', ['e' => $e]);
+    exit(1);
+});
+
+set_error_handler(function ($code, $message, $file, $line) {
+    if ((error_reporting() & $code) === 0) {
+        return false;
+    }
+    // In the future, uncomment this:
+    //throw new \ErrorException($message, 0, $code, $file, $line);
+    $text = sprintf(
+        '%s at %s line %s',
+        sanitize_root($message),
+        sanitize_root($file),
+        $line
+    );
+    RssBridge::getLogger()->warning($text);
+});
+
+// There might be some fatal errors which are not caught by set_error_handler() or \Throwable.
+register_shutdown_function(function () {
+    $error = error_get_last();
+    if ($error) {
+        $message = sprintf(
+            '(shutdown) %s: %s in %s line %s',
+            $error['type'],
+            sanitize_root($error['message']),
+            sanitize_root($error['file']),
+            $error['line']
+        );
+        RssBridge::getLogger()->error($message);
+        if (Debug::isEnabled()) {
+            print sprintf("<pre>%s</pre>\n", e($message));
+        }
+    }
+});
+
 $rssBridge->main($argv ?? []);