Skip to content

Conversation

@gbonnefille
Copy link
Contributor

CSV is a classical input format.

Fixes #1

CSV is a classical input format.
@rykov
Copy link
Owner

rykov commented Jun 20, 2025

CSV is classic. I would inline newCSVReader and unmarshalYamlRecipients because they are quite short and used only once.

@rykov
Copy link
Owner

rykov commented Jun 21, 2025

@gbonnefille Thinking further about this in the context of what I commented on #40, what do you think about moving CSVConfig into the CSV frontmatter? Seems like a better place for it than the global configuration.

@gbonnefille
Copy link
Contributor Author

CSV is classic. I would inline newCSVReader and unmarshalYamlRecipients because they are quite short and used only once.

I have no opinion on such improvment. Feel free to apply any change you consider.

@gbonnefille
Copy link
Contributor Author

@gbonnefille Thinking further about this in the context of what I commented on #40, what do you think about moving CSVConfig into the CSV frontmatter? Seems like a better place for it than the global configuration.

I'm not sure to understand: you want to set the set the Comma property in a comment of the CSV file?

Of course, it seems a good idea as it is clearly coupled with this file.

Nevertheless, as it is a non standard feature, any user will have to edit the (generated) CSV before using it, each time it is regenerated. IMHO, a CSV file is certainly generated from another tool. Having to edit a frontmatter will break a smooth pipeline.

@rykov rykov force-pushed the main branch 4 times, most recently from 4d2f060 to dc9eb47 Compare September 22, 2025 03:36
@rykov
Copy link
Owner

rykov commented Oct 1, 2025

Integrated in 74c8851

@rykov rykov closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSV support for Recipient Lists

2 participants