Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spending limits] Non-owners with a spending limit allowance cannot interact with the Safe #1561

Closed
katspaugh opened this issue Jan 19, 2023 · 2 comments · Fixed by #1572
Closed
Assignees
Labels
enhancement New feature or request major Major bug (to be solved in the next release)
Milestone

Comments

@katspaugh
Copy link
Member

Bug description

It's possible to add spending limits to any Ethereum address, even non-owners. However, the UI still shows that Safe as "read-only" for such users.

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Ethereum mainnet

Steps to reproduce

  1. Add a spending limit to a non-owner
  2. Try to make a transaction (bummer!)
@katspaugh katspaugh added bug major Major bug (to be solved in the next release) labels Jan 19, 2023
@iamacook
Copy link
Member

For reference, a delegate management PoC was worked on in the past here (though safe-react-based) and I prepared the types for the delegate endpoints for it as well.

@liliya-soroka liliya-soroka added enhancement New feature or request and removed bug labels Jan 19, 2023
@katspaugh
Copy link
Member Author

It might be not necessary to delegate, @francovenica says it's possible to create these transactions on the contract level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request major Major bug (to be solved in the next release)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants