Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Safe creation] - Changing owner during the process should change it in the step 3 as well #806

Closed
francovenica opened this issue Oct 5, 2022 · 1 comment
Assignees
Labels
major Major bug (to be solved in the next release)

Comments

@francovenica
Copy link
Contributor

Bug description

While logged in MM (a wallet were you can change address at will), if you are in the step 3 and change address then the 1st owner of the safe being created should also change.

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: any (but tested in goerli)

Steps to reproduce

  1. Go to safe creation
  2. Reach step 3
  3. Change owners in MM

Expected result

The 1st owner of the safe being created changes to the one you changed in MM

Obtained result

The owner remains the same

Screenshots

safe creation

@usame-algan usame-algan self-assigned this Oct 5, 2022
@usame-algan
Copy link
Member

usame-algan commented Oct 6, 2022

@francovenica we discussed this in the daily and decided to not port it over for now as it is interfering with the UX too much without giving proper feedback. A few alternative ideas came up like displaying a button to reset back to the connected wallet address or displaying a warning if the account has changed. I suggest we look into possible solutions in the context of safe-global/safe-pm#82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Major bug (to be solved in the next release)
Projects
None yet
Development

No branches or pull requests

2 participants