test: GCP IAM policy APIs integ tests #189
Conversation
Yaminik1996
force-pushed
the
W-20342061/iamGcpConformanceTesting
branch
from
7784cca to
81cf519
Compare
There was a problem hiding this comment.
These are being created because of the truncation settings done in TestUtils.java.
.extractBinaryBodiesOver(4096*2)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
============================================
+ Coverage 83.60% 83.62% +0.02%
- Complexity 90 91 +1
============================================
Files 150 150
Lines 8087 8087
Branches 944 944
============================================
+ Hits 6761 6763 +2
+ Misses 877 876 -1
+ Partials 449 448 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| .withBodyFile(bodyFileName).build()); | ||
| } | ||
| } catch (Exception e) { | ||
| logger.warn("Failed to mask PII in response body: {}", e.getMessage()); |
There was a problem hiding this comment.
it shoudn't be warn, we should block it.
| // Then retrieve it | ||
| String policyDetails = iamClient.getInlinePolicyDetails( | ||
| harness.getIdentityName(), | ||
| "roles/storage.objectViewer", // policy name (role name in GCP) |
There was a problem hiding this comment.
abstract class is meant to be cloud agnostic, please remove gcp specific values from here, there are other places as well
| .action("roles/storage.objectViewer") | ||
| .action("roles/storage.objectCreator") |
| .action("roles/storage.objectViewer") | ||
| .action("roles/storage.objectCreator") |
sandeepvinayak
left a comment
sandeepvinayak
left a comment
There was a problem hiding this comment.
please fix the gcp values from abstract class
Yaminik1996
force-pushed
the
W-20342061/iamGcpConformanceTesting
branch
from
81cf519 to
d9b55e3
Compare
3 participants
Summary
< Provide a brief description of the changes in this PR >
Some conventions to follow
docstore:for document store module,blobstorefor Blob Store moduletest:perf: