Include arguments as part of cache_key in custom preloads

[mintuhouse]

There may be cases where we want to preload instance methods which accept arguments
e.g.,

def custom_count(condition)
   goldiload("custom_count_#{condition.inspect}") do |ids|
     # logic to return condition based counts for all ids
   end
end

Model.all do |m|
  m.custom_count(condition1) # Would fire a single query for all model instances
  m.custom_count(condition2) # Would fire another query for all model instances
end

• Are there any downsides to including it that way
• If its ok to do so, thinking if passing another optional kwarg cache_args = [] which can be appended to existing cache_key in

  goldiloader/lib/goldiloader/active_record_patches.rb

  Line 30 in df2cba4

  cache_name ||= block.source_location.join(':')

  make its usage obvious to future users of that API

[jturkel]

Yup. That should work using the existing cache_name argument. The biggest downside is the cached values will be in the in-memory cache as long as the corresponding models are in memory. It should be find under most circumstances but could become problematic if you invoke this method will lots of different arguments.

I'd rather not complicate the API with another parameter for a case that likely isn't very common. I'd definitely be willing to accept a PR to add this recommendation to the README.md though.