Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend /health endpoints to make them async and detailed #54

Closed
karntrehan opened this issue Apr 6, 2023 · 6 comments
Closed

Extend /health endpoints to make them async and detailed #54

karntrehan opened this issue Apr 6, 2023 · 6 comments
Assignees
@chinmoy12c

Comments

@karntrehan
Copy link
Contributor

karntrehan commented Apr 6, 2023 •
edited
Loading

Current /health endpoints of services are not very intuitive. They are also synchronous leading to blockages of 4 seconds on each call to /health.

We should make them async and also check internal working like kafka giving 500s.
@karntrehan karntrehan changed the title Extend /health endpoints for monitoring kafka for 500 error when an event happens Extend /health endpoints to make them async and detailed Apr 6, 2023
@karntrehan
Copy link
Contributor Author

karntrehan commented Apr 10, 2023 •
edited
Loading

@chinmoy12c to document the schema here. Some tests need to be fixed.

@karntrehan karntrehan mentioned this issue Apr 10, 2023
Closed
@karntrehan
Copy link
Contributor Author

karntrehan commented Apr 11, 2023 •
edited
Loading

Pr raised. @pankajjangid05 & @surabhi-mahawar to review.

@chinmoy12c
Copy link
Member

The response JSON schema needs to be changed. @tushar5526 please add the required schema.

@tushar5526
Copy link
Collaborator

The /health schema should follow this template response, so that we can get the status of dependent services as well.

Response Format - https://yaus.xyz/health

@chinmoy12c
Copy link
Member

chinmoy12c commented Apr 18, 2023 •
edited
Loading

These are the PRs @pankajjangid05

samagra-comms/transformer#63
samagra-comms/orchestrator#32
samagra-comms/inbound#40
samagra-comms/outbound#26
samagra-comms/utils#39
samagra-comms/dao#11

@pankajjangid05
Copy link
Contributor

@chinmoy12c These PRs are merged.

@chinmoy12c chinmoy12c reopened this May 3, 2023
@chinmoy12c chinmoy12c mentioned this issue May 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chinmoy12c chinmoy12c

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@karntrehan @tushar5526 @chinmoy12c @pankajjangid05