Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure only a user in a leadership role can cancel an event for a patrol #25

Open
3 tasks done
clue4 opened this issue Nov 13, 2022 · 1 comment
Open
3 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@clue4
Copy link
Collaborator

clue4 commented Nov 13, 2022

Problem: Right now, any person logged in on an account and in a patrol can cancel events for that patrol, including accounts that are only scouts.
Solution: Ensure that only leadership type accounts (Patrol leaders, Scout Masters) can only cancel events

Specs:

  • Only leadership roles can delete events in their patrol
    • patrol leaders including senior patrol leaders, assistant patrol leaders
    • scoutmasters including assistant scout masters

Additional:
Hoping this is as straightforward as hiding the cancel event button with maybe some additional frontend changes but if this takes you into the backend please let me know!

image

@clue4 clue4 added the enhancement New feature or request label Nov 13, 2022
@clue4 clue4 moved this to Todo in ScoutTrek Kanban Board Nov 13, 2022
@SimChadha SimChadha moved this from Todo to In Progress in ScoutTrek Kanban Board Jan 22, 2023
@KobeZ123 KobeZ123 moved this from In Progress to Pull Request in ScoutTrek Kanban Board Feb 5, 2023
@KobeZ123
Copy link

KobeZ123 commented Feb 5, 2023

The changes should be done in the 'cancel-event' branch and a backend 'cancel-event' branch was also made for the deleteEvent resolver.

@SimChadha SimChadha moved this from Pull Request to Done in ScoutTrek Kanban Board Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants