Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create and test music submission procedure #114

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amolipatel05
Copy link
Contributor

@amolipatel05 amolipatel05 commented Feb 26, 2025

Description

Motivation and Context

Closes STORY NAME HERE

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Global styling changes
  • New package(s)
  • New dependencies
  • Project configuration
  • Environment variable update
  • Database migration
  • CI/CD changes (changing github actions or deployment scripts)

Checklist:

  • I verified my changes work in the local environment
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I verified my changes work in the preview environment

How has this been tested?

Screenshots (if appropriate):

@amolipatel05 amolipatel05 linked an issue Feb 26, 2025 that may be closed by this pull request
Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
good-dog-licensing ❌ Failed (Inspect) Mar 12, 2025 2:10am


import { authenticatedProcedureBuilder } from "../middleware/authentictated";

// add a test verifying that inputting an invalid groupId results in an error
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove this comment if done

)

.mutation(async ({ ctx, input }) => {
// Check if the user is a Musician or an Admin
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once gavin/Jordans PRs are merged in, we can use the middleware to handle this error case

import { MockNextCookies } from "../mocks/MockNextCookies";
import { createMockCookieService } from "../mocks/util";

//bun db:studio
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove this :P

});

beforeAll(async () => {
const person1 = await prisma.user.upsert({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can simplify these prisma queries at some point, once everything else is set

@@ -1,6 +1,7 @@
import { PrismaClient } from "@prisma/client";
import { PrismaClient, Role } from "@prisma/client";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need to import if we are exporting directly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit Endpoint for Music Submissions
2 participants