Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for parsed majors in production #13

Open
rael346 opened this issue Feb 9, 2024 · 1 comment
Open

Tests for parsed majors in production #13

rael346 opened this issue Feb 9, 2024 · 1 comment

Comments

@rael346
Copy link
Contributor

rael346 commented Feb 9, 2024

This ticket is mainly for backwards compatibility. Since we are iterating on a large amount of majors while still supporting the already hand validated majors in the GraduateNU's backend, we need to ensure:

  • Changes we make to fix the newer majors doesn't break the old ones
  • Have fix for hand validated errors that the scraper can handle

Current tests in scrapers are fairly rudimentary and doesn't address many edge cases that the major catalog is notorious for.

A few guidelines

  • Errors that are mainly parser responsibility, i.e. the tokens are correct but the parser parses it incorrectly should be tests in parse.test.ts
  • Errors that stems from tokens being wrong (not tokenizing a comment as a XOM, etc) should be in tokenize.test.ts
  • Snapshot tests should be reserved for majors that has a distinct quality (Business with their separated concentration pages, etc)
@riddhigupta06
Copy link

Run major scraper for a given major and year. Check the errors that arise by using the hand validated majors in graduate's backend.

Document interesting cases and figure out tests we can write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants