Mobile Header Redesign #324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- initial styles - separation of mobile and desktop components - still need to make mobile searchbar and semesterdropdown
- needs styling changes but functional
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The filter drawer should probably be branched off of here since they are related. |
|
Love you Carter, will review tmrw. Also have @ananyaspatil look over it for design compliance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Change the mobile header to match the designs. Closes #313
Tickets
Contributors
Feature List
Pictures
Before:
After:
Reviewers
Primary:
Secondary reviewers: