Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextjs optional followups #55

Open
11 of 15 tasks
dajinchu opened this issue Dec 28, 2020 · 0 comments
Open
11 of 15 tasks

nextjs optional followups #55

dajinchu opened this issue Dec 28, 2020 · 0 comments
Assignees
@dajinchu @NEUDitao

Comments

@dajinchu
Copy link
Member

dajinchu commented Dec 28, 2020 •
edited by hankewyczz
Loading

Follow ups from #49 #56

Just miscellaneous TODOS we're finding from Next.js transition that would be too much to do in the initial PR.

  • AbstractMacros can be killed + macros can be split up into utils folder. Some of it can be moved closer to where it is used.
  • Various files sitting in top level of components can be moved to utils I think?
  • turn on strict null (this should wait until at least Remove Keys.js from frontend #59 is done)
  • search using graphql (blocked by the issues listed in course catalog api
  • Eslint/Prettier setup Next js prettier #57
  • docs Nextjs Docs #58
  • Paths. Search should be /search or something. Add /:campus in front of stuff. /202030 should be the home page, not the empty search result.

Reduce bundle size
image

  • get rid of semantic entirely

  • CSS splitting

  • migrate out of moment.js (use luxon)

  • Get rid of URIjs

  • generate sitemap

  • turn app into useSWR and maybe use a new request library

  • turn search into useSWR

  • sanitize search by htmlicizing it
@dajinchu dajinchu changed the title nextjs followups nextjs optional followups Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dajinchu dajinchu

@NEUDitao NEUDitao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dajinchu @NEUDitao