linting fixes

Author: tjfulle

src/hpcc_remote/submit.py

@@ -36,9 +36,8 @@ def __init__(
         output: str | None = None,
         error: str | None = None,
     ) -> None:
-        sh = shutil.which("sh")
         ssh = shutil.which("ssh")
-        if sh is None:
+        if ssh is None:
             raise RuntimeError("ssh not found on PATH")
         stdout = streamify(output)
         if stdout is not None:
@@ -108,7 +107,6 @@ def polling_frequency(self) -> float:
     def submit(
         self,
         name: str,
-        host: str,
         args: list[str],
         scriptname: str | None = None,
         qtime: float | None = None,
@@ -121,6 +119,9 @@ def submit(
         gpus: int | None = None,
         **kwargs: Any,
     ) -> HPCProcess:
+        host = kwargs.get("host")
+        if host is None:
+            raise ValueError("missing required kwarg 'host'")
         cpus = cpus or kwargs.get("tasks")  # backward compatible
         script = self.write_submission_script(
             name,

tests/pbs.py

@@ -44,6 +44,6 @@ def test_basic():
     assert "#PBS -l walltime=00:00:01" in text
     assert "#PBS -o my-out.txt" in text
     assert "#PBS -e my-err.txt" in text
-    assert "export MY_VAR=SPAM" in text
+    assert 'export MY_VAR="SPAM"' in text
     assert "printenv || true" in text
     assert "ls" in text

tests/slurm.py

@@ -44,7 +44,7 @@ def test_basic():
     assert "#SBATCH --job-name=my-job" in text
     assert "#SBATCH --error=my-err.txt" in text
     assert "#SBATCH --output=my-out.txt" in text
-    assert "export MY_VAR=SPAM" in text
+    assert 'export MY_VAR="SPAM"' in text
     assert "printenv || true" in text
     assert "ls" in text