Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Germ selection has same outcome labels bug as fiducial selection #507

Closed
pcwysoc opened this issue Nov 22, 2024 · 2 comments
Closed

Germ selection has same outcome labels bug as fiducial selection #507

pcwysoc opened this issue Nov 22, 2024 · 2 comments
Assignees
Labels
bug A bug or regression likely quick Things we expect to not take significant investigation or changes (remove label if issue spirals)
Milestone

Comments

@pcwysoc
Copy link
Contributor

pcwysoc commented Nov 22, 2024

Describe the bug
Outcome labels of germ selection have the same bug as fiducial selection (#396 for more details):

Screenshot 2024-11-22 at 9 48 35 AM
@pcwysoc pcwysoc added the bug A bug or regression label Nov 22, 2024
@pcwysoc
Copy link
Contributor Author

pcwysoc commented Nov 25, 2024

@coreyostrove I think this should do the trick if added at line 403 in germselection.py (at the end of the 'find_germs' function):

finalGermList = []
for ckt in germList:
    if ckt._static:
        new_ckt = ckt.copy(editable=True)
        new_ckt.line_labels = target_model.state_space.state_space_labels
        print(new_ckt.line_labels)
        new_ckt.done_editing()
        finalGermList.append(new_ckt)
    else:
        ckt.line_labels = target_model.state_space.state_space_labels
        finalGermList.append(ckt)

return finalGermList

@sserita sserita added this to the 0.9.13.1 milestone Jan 16, 2025
@sserita sserita added the likely quick Things we expect to not take significant investigation or changes (remove label if issue spirals) label Jan 17, 2025
@coreyostrove
Copy link
Contributor

Closing as fix was merged in with PR #540.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug or regression likely quick Things we expect to not take significant investigation or changes (remove label if issue spirals)
Projects
None yet
Development

No branches or pull requests

3 participants