Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y25-128 - [BUG] Determine root cause of Bioscan page loading issue #2230

Open
KatyTaylor opened this issue Feb 19, 2025 · 4 comments · Fixed by sanger/sequencescape#4697
Open
Labels

Comments

@KatyTaylor
Copy link
Contributor

KatyTaylor commented Feb 19, 2025

Describe the bug
Determine the root cause of Fresh Service ticket #SR-22290

It was caused by something in this PR - sanger/sequencescape#4635 - the removal of default_includes

Determine if we can remove default_includes or not.

To Reproduce
Steps to reproduce the behaviour:

  1. Go to Limber home page (training or prod)
  2. Search for tube NT1851117I (or any other Bioscan 'LBSN-9216 Lib PCR Pool' tube containing 9216 samples)
  3. Page fails to load with 500 error, and the following error coming through as an exception email:
A JsonApiClient::Errors::ConnectionError occurred in tubes#show:

  Net::ReadTimeout with #<TCPSocket:(closed)>
  app/sequencescape/sequencescape/api/v2/tube.rb:43:in `find_by'

Expected behaviour
Page should load successfully (it still takes a long time though).

@KatyTaylor KatyTaylor added the Bug Bug in code label Feb 19, 2025
@psd-issuer psd-issuer bot changed the title [BUG] Determine root cause of Bioscan page loading issue Y25-128 - [BUG] Determine root cause of Bioscan page loading issue Feb 19, 2025
@KatyTaylor
Copy link
Contributor Author

Andrew and Abdullah have already been looking into whether the default_includes API changes have had any effect.

@KatyTaylor
Copy link
Contributor Author

KatyTaylor commented Feb 19, 2025

To find more tubes to test using:

SELECT l.id, b.barcode
FROM labware l 
JOIN plate_purposes pp ON pp.id = l.plate_purpose_id
JOIN barcodes b ON b.asset_id = l.id
WHERE pp.name = 'LBSN-9216 Lib PCR Pool'
ORDER BY l.created_at DESC;

@KatyTaylor
Copy link
Contributor Author

KatyTaylor commented Feb 19, 2025

Testing if default_includes PR was the issue (it was)

Test 1:
Versions:

Result:
Tube pages for the following did load successfully:

  • NT1851117I (didn’t time it)
  • NT1850823A (46 / 44 / 47 seconds)

Test 2:
Versions:

Result:
Tube pages for the following did not load successfully:

  • NT1851117I (500 error at 60 seconds)
  • NT1850823A (500 error at 60 seconds)

@TWJW-SANGER
Copy link

Probably should be open....

@TWJW-SANGER TWJW-SANGER reopened this Mar 3, 2025
@KatyTaylor KatyTaylor removed their assignment Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants