No Info.plist file in application bundle or no NSPrincipalClass in the Info.plist file

[hintofbasil]

Describe the bug
I am getting intermittent errors from the application failing to connect to my Github server. These errors come in the form of notifications. Checking the logs they contain 2020-08-06 09:46:25 ERROR Failed to connect to https://REDACTED/api/v3/notifications.
I have never successfully received a proper notification. Inspecting further I was am getting the failed to connect notification only when there is a new notification.

Running the tool manually I get no output and a response code of 0 when there are no notification updates. But when there is a notification update I get the error 2020-08-06 15:39:28.419 terminal-notifier[16497:137323] No Info.plist file in application bundle or no NSPrincipalClass in the Info.plist file, exiting.

To Reproduce
Steps to reproduce the behavior:

1. Trigger a notification
2. Run /usr/local/lib/github_notif before the tool runs automatically.

Expected behavior
I expected to see details of the notification

Screenshots
N/A

Desktop (please complete the following information):

• OSX version: 10.14.6 (18G103)

Additional context
N/A

[sargsyan]

@hintofbasil sorry for the late reply. Seems that "Failed to connect to https://REDACTED/api/v3/notifications" is a misleading error message and the real issue is the terminal-notifier binary. Could you try to call terminal-notifier from your terminal?

An example:

terminal-notifier -message hey

[hintofbasil]

terminal-notifier -message hey works fine. Notification appears with the correct message.

[sargsyan]

Ok, then let's look at the first problem. Could you open the file /usr/local/Cellar/github-notifier/<current_version:the latest is 1.0.7>/lib/github_notif and replace the following code

    if [[ "$config_name" == "https://github.com" ]]; then
      notifications_api_url="${config_name/https:\/\//https://api.}"/notifications
    else
      notifications_api_url="${config_name}/api/v3/notifications"
    fi

with the following?

    notifications_api_url="${config_name/https:\/\//https://api.}"/notifications

Unfortunately, I don't have access to a GitHub enterprise account to test it myself.

[hintofbasil]

Apologies for the slow response here.

I've tried making the above changes. This results in 2020-10-06 22:25:27 ERROR Failed to connect to https://api.REDACTED/notifications when running the application.

I've checked the two endpoints and /api/v3/notification is definitely correct for the Github version we are using 2.20.12.