Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests dependencies #159

Open
Youssef1313 opened this issue Sep 4, 2020 · 0 comments
Open

Tests dependencies #159

Youssef1313 opened this issue Sep 4, 2020 · 0 comments
Labels
type/testing Missing or broken tests

Comments

@Youssef1313
Copy link

I haven't yet dug into reading the source code carefully, but as a quick note, I see the Tests project depends on the Editor project.

I believe the Editor project should be only responsible for the "Web" things. Hence, it's just a high-level layer that depends on the lower-level components.

Given that, I don't think the Tests project should have a dependency on this web project.

The needed dependency could be for one of the following two reasons:

  1. The tests actually test things related to the web project. In that case, I think there should be a new test project for integration tests.
  2. The web project itself contains code that should have been in a different layer, causing the Tests project to have a dependency on it just to test things that aren't actually related to web.

Please, correct me if I'm wrong.

@nonkit nonkit added the type/testing Missing or broken tests label Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/testing Missing or broken tests
Projects
None yet
Development

No branches or pull requests

2 participants