Skip to content

Commit 6119a1d

Browse files
committed
fix(tests): update integration tests after rebase on main
Two test-only fixes surfaced when the PR rebased on top of #1320 + - `BanListIpColumnTest::renderBanList` (from #1320) constructs a `BanListView` with positional + named arguments. This PR adds a 28th constructor parameter (`is_advanced_search_open`) which the test must now pass — default it to `false` so the IP-column suite stays exercising the column-render contract it was written for, not the disclosure state. - `ServerMapImageRenderTest::testHandlerStillEmitsMapimgField` (from #1326) asserted a literal `"'mapimg' => GetMapImage("` substring in `web/api/handlers/servers.php`. #1329's cache + debounce rewrite shifted the surrounding column alignment to 5 spaces, breaking the brittle match without changing the contract the test guards (the field is still emitted). Switch to a regex that tolerates any whitespace between the key and `=>` so a future alignment shift doesn't silently re-trigger the same false positive.
1 parent 6596ace commit 6119a1d

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

‎web/tests/integration/BanListIpColumnTest.php‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -208,6 +208,7 @@ private function renderBanList(bool $hideplayerips, ?array $banList = null): str
208208
is_filtered: false,
209209
server_list: [],
210210
filters: ['search' => '', 'server' => '', 'time' => ''],
211+
is_advanced_search_open: false,
211212
);
212213

213214
ob_start();

0 commit comments

Comments
 (0)