Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingest proper headwords for Lexicon Thucydideum #191

Open
1 of 2 tasks
jacobwegner opened this issue Dec 28, 2023 · 1 comment
Open
1 of 2 tasks

Ingest proper headwords for Lexicon Thucydideum #191

jacobwegner opened this issue Dec 28, 2023 · 1 comment

Comments

@jacobwegner
Copy link
Contributor

jacobwegner commented Dec 28, 2023 •
edited
Loading

  • Short term: Grab from the n attribute
  • Longer term: Add as an attr on the head element
jacobwegner added a commit that referenced this issue Dec 28, 2023
@jacobwegner
Improve headword extraction for Lexicon Thucydideum
3bbe75a 
refs #191
@jacobwegner jacobwegner mentioned this issue Dec 28, 2023
Merged
@jacobwegner
Copy link
Contributor Author

@gregorycrane I've just deployed an updated version to Beyond Translation

Before:
image

After:
image

https://beyond-translation.perseus.org/reader/urn:cts:greekLit:tlg0012.tlg001.perseus-grc2:1.1-1.7?mode=dictionary-entries.

I'll leave this issue open so we can update the extractor to look for a unicode value directly on head; you can see the "short-term" fix I took on #192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacobwegner