Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release for Scala 2.13.0-RC3 #214

Closed
Philippus opened this issue May 29, 2019 · 18 comments
Closed

Release for Scala 2.13.0-RC3 #214

Philippus opened this issue May 29, 2019 · 18 comments
Assignees

Comments

@Philippus
Copy link
Member

Philippus commented May 29, 2019

Tag v1.1.2#2.13.0-RC3#8 has been created, @SethTisue can you pick it up from here?

@SethTisue
Copy link
Member

@SethTisue SethTisue self-assigned this May 29, 2019
@Philippus
Copy link
Member Author

Looks like the scala native artifacts also got published, we could release those as well?

@SethTisue
Copy link
Member

sure, I see them on Sonatype. I'm in the middle of closing and releasing the staging repos.

@SethTisue
Copy link
Member

SethTisue commented May 29, 2019

sigh, something went wrong — one .asc file ended up in a staging repo all by itself, and then the whole batch failed Sonatype's checks. can you delete and then re-push the tag?

very likely it's just some race condition that will go away on retry

@Philippus
Copy link
Member Author

@SethTisue
Copy link
Member

shouldn't the staging repos have contained artifacts for 2.13.0-RC3 only? there were tons of 11 and 12 artifacts too. including the Scala Native artifacts. which should have tipped me off, but I'm sleepy

going to bed now, I'll look at it in the morning. (I'm in Europe early for Scala Days.)

I'm having deja vu. did this also happen last time? I can't remember if it was in this repo, or a different module repo. any clue why the tag parsing stuff isn't doing the right thing?

@SethTisue
Copy link
Member

yeah it did happen here last time: #211 (comment)

@SethTisue
Copy link
Member

scala-xml has the same problem, scala/scala-xml#311

@SethTisue
Copy link
Member

SethTisue commented May 30, 2019

oh okay, this is just how things work now, after #174. I got confused because some other modules still do it the old way

okay, I see now that it is:

# In order to build a previously released version against a new (binary incompatible) Scala release,
# a new commit that modifies (and prunes) the Scala versions in .travis.yml needs to be added on top
# of the existing tag. Then a new tag can be created for that commit, e.g., `v1.2.3#2.13.0-M5`.
# Everything after the `#` in the tag name is ignored.

@SethTisue
Copy link
Member

SethTisue commented May 30, 2019

hmm well that didn't work. it only published locally, not to Sonatype

it seems not to have gone into this if in admin/build.sh:

verPat="[0-9]+\.[0-9]+\.[0-9]+(-[A-Za-z0-9-]+)?"
tagPat="^v$verPat(#$verPat#[0-9]+)?$"

if [[ "$TRAVIS_TAG" =~ $tagPat ]]; then
  tagVer=${TRAVIS_TAG}
  tagVer=${tagVer#v}   # Remove `v` at beginning.
  tagVer=${tagVer%%#*} # Remove anything after `#`.
  publishVersion='set every version := "'$tagVer'"'

I 😐 regexes and shell scripting

@SethTisue
Copy link
Member

It appears that contrary to the comment in admin/build.sh, the #8 at the end is required after all, note the two appearances of # in tagPat

@SethTisue
Copy link
Member

staging repos closed, released.

now we keep an eye out at https://repo1.maven.org/maven2/org/scala-lang/modules/scala-parser-combinators_2.13.0-RC3/1.1.2/

@SethTisue
Copy link
Member

@SethTisue
Copy link
Member

@Philippus now we both know better for next time :-)

@Philippus
Copy link
Member Author

let's not change it until after 2.13.0 final is out. :)

@SethTisue
Copy link
Member

@Philippus since you don't do Twitter (afaict), fyi https://twitter.com/SethTisue/status/1133836388615544833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants