Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish for Scala 2.13.0-RC3 #316

Closed
SethTisue opened this issue May 29, 2019 · 10 comments
Closed

publish for Scala 2.13.0-RC3 #316

SethTisue opened this issue May 29, 2019 · 10 comments

Comments

@SethTisue
Copy link
Member

@ashawley if you happen to be awake and available, lmk, otherwise I can do it. PR is #315

@SethTisue
Copy link
Member Author

PR merged

@SethTisue
Copy link
Member Author

@ashawley I see you pushed a tag, but then https://travis-ci.org/scala/scala-xml/builds/538964180 shows as "canceled"?

@SethTisue
Copy link
Member Author

I see that the RC2 and RC3 tags are orphan commits (not on any branch that) use .travis.yml to cut the matrix down to just RC2/RC3

oh, I see now that's because over at #311 the thing of using the tag name to restrict the Scala versions didn't work

and we're having the same problem over at scala/scala-parser-combinators#214

@SethTisue
Copy link
Member Author

is this just how things work now, since #223?

@SethTisue
Copy link
Member Author

okay, I see now that it is:

# In order to build a previously released version against a new (binary incompatible) Scala release,
# a new commit that modifies (and prunes) the Scala versions in .travis.yml needs to be added on top
# of the existing tag. Then a new tag can be created for that commit, e.g., `v1.2.3#2.13.0-M5`.
# Everything after the `#` in the tag name is ignored.

@SethTisue
Copy link
Member Author

SethTisue commented May 30, 2019

over at scala/scala-parser-combinators#214 we found that the regex in admin/build.sh expects the old two-# format like v1.2.3#2.13.0-M5#8

but in this repo, admin/build.sh is different:

tagPat="^v$verPat(#.*)?$"

so we shouldn't need an extra #8 at the end

@SethTisue
Copy link
Member Author

@SethTisue
Copy link
Member Author

staging repos closed, released.

now we keep an eye out at https://repo1.maven.org/maven2/org/scala-lang/modules/scala-xml_2.13.0-RC3/1.2.0/

@SethTisue
Copy link
Member Author

@ashawley
Copy link
Member

Thanks for getting scala-xml published. All Travis builds seemed to stall out for me last night, not just the tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants