Add `library.properties` to resources of scala-library jars #24332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

WojciechMazur merged 2 commits into scala:main from zielinsky:i22144

Nov 6, 2025

+69 −57

Member

zielinsky commented Nov 4, 2025

Fixes #22144


          add properties file for scala3 library

c8ae057

zielinsky force-pushed the i22144 branch from b50bed8 to c8ae057 Compare

November 4, 2025 12:30

WojciechMazur reviewed

View reviewed changes

library/src/scala/util/Properties.scala Outdated Show resolved Hide resolved

WojciechMazur reviewed

View reviewed changes

project/Build.scala Outdated Show resolved Hide resolved

WojciechMazur reviewed

View reviewed changes

project/Build.scala Outdated Show resolved Hide resolved

WojciechMazur reviewed

View reviewed changes

project/Build.scala Outdated Show resolved Hide resolved

Contributor

som-snytt commented Nov 5, 2025

It's been a while since I used the old shell banner, but when I did, it inspired me with community spirit!

WojciechMazur reviewed

View reviewed changes

tests/run/properties-version-string.scala Show resolved Hide resolved

zielinsky force-pushed the i22144 branch 5 times, most recently from 2aaf1a1 to 21f2778 Compare

November 5, 2025 10:25

WojciechMazur reviewed

View reviewed changes

tests/run/properties-version-string.scala Outdated Show resolved Hide resolved

WojciechMazur reviewed

View reviewed changes

tests/run/properties-version-string.scala Outdated Show resolved Hide resolved

WojciechMazur reviewed

View reviewed changes

project/Build.scala Outdated Show resolved Hide resolved

zielinsky force-pushed the i22144 branch from 21f2778 to 75a2f38 Compare

November 5, 2025 11:41

zielinsky marked this pull request as ready for review

November 5, 2025 11:59

zielinsky requested a review from WojciechMazur

November 5, 2025 12:11

zielinsky force-pushed the i22144 branch from 75a2f38 to bdfe938 Compare

November 5, 2025 12:47


          address review

zielinsky force-pushed the i22144 branch from bdfe938 to 2358466 Compare

November 5, 2025 16:28

WojciechMazur approved these changes

View reviewed changes

WojciechMazur changed the title ~~Add library3.properties~~ Add library.properties to resources of scala-library jars

WojciechMazur merged commit 9e26ce6 into scala:main

53 checks passed

WojciechMazur added the backport:nominated label

WojciechMazur added this to the 3.8.0 milestone

WojciechMazur pushed a commit that referenced this pull request


          Add library.properties to resources of scala-library jars (#24332)

2b9c021

Fixes #22144
[Cherry-picked 9e26ce6]

WojciechMazur mentioned this pull request

Backport "Add library.properties to resources of scala-library jars" to 3.8.0 #24396

Merged

WojciechMazur added a commit that referenced this pull request


          Backport "Add library.properties to resources of scala-library jars…

5611a78

…" to 3.8.0 (#24396)

Backports #24332 to the 3.8.0-RC1.

PR submitted by the release tooling.
[skip ci]

WojciechMazur added backport:done and removed backport:nominated labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels