Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video Component Broken #56

Closed
CryogenicPlanet opened this issue Aug 6, 2020 · 1 comment · Fixed by #93
Closed

Video Component Broken #56

CryogenicPlanet opened this issue Aug 6, 2020 · 1 comment · Fixed by #93
Assignees
@CryogenicPlanet
Labels
bug Something isn't working

Comments

@CryogenicPlanet
Copy link
Member

  • Play/Pause button SVG not correct and not working
  • Fullscreen mode crashes react

Related to #54, should be solved together

Requires Firefox 79 or greater
@CryogenicPlanet CryogenicPlanet added the bug Something isn't working label Aug 6, 2020
@CryogenicPlanet CryogenicPlanet changed the title Video Component Broken in Firefox Video Component Broken Aug 11, 2020
@CryogenicPlanet
Copy link
Member Author

Expand the Error, Play Pause broken in Edge too

In local environment get critical errors for play/pause in firefox and get critical error for fullscreen in both

Related https://stackoverflow.com/questions/47893690/how-to-play-an-audio-file-from-an-external-url-using-javascript

CryogenicPlanet added a commit that referenced this issue Aug 14, 2020
@CryogenicPlanet
❌Video Play/Pause Error
584da3b 
- Tied to #56
CryogenicPlanet added a commit that referenced this issue Aug 14, 2020
@CryogenicPlanet
❌Video Play/Pause Error
7338456 
- Tied to #56
CryogenicPlanet added a commit that referenced this issue Aug 30, 2020
@CryogenicPlanet
Visual Solve #56 on Firefox
11cffcc
@CryogenicPlanet CryogenicPlanet mentioned this issue Sep 19, 2020
Open
CryogenicPlanet added a commit that referenced this issue Oct 27, 2020
@CryogenicPlanet
✨ New video player
9adc70f 
- Fixes Video Component Broken #56 and Fixes Video Cropping #54
@CryogenicPlanet CryogenicPlanet mentioned this issue Oct 27, 2020
Merged
CryogenicPlanet added a commit that referenced this issue Oct 27, 2020
@CryogenicPlanet
✨ New video player
f84be5e 
- Fixes Video Component Broken #56 and Fixes Video Cropping #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CryogenicPlanet CryogenicPlanet

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Adding gif support scalarhq/videotranscode.space
2 participants
@CryogenicPlanet @rithvikmahin