test(mnq): extract helper functions to simplify tests

Author: jremy42

internal/namespaces/mnq/v1beta1/custom_nats_test.go

@@ -32,43 +32,11 @@ func Test_CreateContext(t *testing.T) {
 					Replacement: "Select context using `nats context select context-placeholder`",
 				},
 			),
-			func(t *testing.T, ctx *core.CheckFuncCtx) {
-				t.Helper()
-				result, isSuccessResult := ctx.Result.(*core.SuccessResult)
-				assert.True(
-					t,
-					isSuccessResult,
-					"Expected result to be of type *core.SuccessResult, got %s",
-					reflect.TypeOf(result).String(),
-				)
-				assert.NotNil(t, result)
-				expectedContextFile := result.Resource
-				if !mnq.FileExists(expectedContextFile) {
-					t.Errorf(
-						"Expected credentials file not found expected [%s] ",
-						expectedContextFile,
-					)
-				} else {
-					ctx.Meta["deleteFiles"] = []string{expectedContextFile}
-				}
-			},
+			checkContextFile,
 		),
 		AfterFunc: core.AfterFuncCombine(
 			deleteNATSAccount("NATS"),
-			func(ctx *core.AfterFuncCtx) error {
-				if ctx.Meta["deleteFiles"] == nil {
-					return nil
-				}
-				filesToDelete := ctx.Meta["deleteFiles"].([]string)
-				for _, file := range filesToDelete {
-					err := os.Remove(file)
-					if err != nil {
-						t.Errorf("Failed to delete the file : %s", err)
-					}
-				}
-
-				return nil
-			},
+			afterFuncDeleteFiles,
 		),
 	}))
 }
@@ -135,6 +103,50 @@ func beforeFuncCopyConfigToTmpHome() core.BeforeFunc {
 	})
 }
 
+func checkContextFile(t *testing.T, ctx *core.CheckFuncCtx) {
+	t.Helper()
+	result, isSuccessResult := ctx.Result.(*core.SuccessResult)
+	assert.True(t, isSuccessResult, "Expected result to be of type *core.SuccessResult, got %s", reflect.TypeOf(result).String())
+	assert.NotNil(t, result)
+	expectedContextFile := result.Resource
+	if !mnq.FileExists(expectedContextFile) {
+		t.Errorf("Expected credentials file not found expected [%s]", expectedContextFile)
+	} else {
+		ctx.Meta["deleteFiles"] = []string{expectedContextFile}
+	}
+}
+
+func checkContextFileInXDGConfigHome(t *testing.T, ctx *core.CheckFuncCtx) {
+	t.Helper()
+	checkContextFile(t, ctx)
+
+	result := ctx.Result.(*core.SuccessResult)
+	expectedContextFile := result.Resource
+	xdgConfigHome := ctx.OverrideEnv["XDG_CONFIG_HOME"]
+	tmpHomeDir := ctx.OverrideEnv["HOME"]
+
+	expectedContextDir := filepath.Join(xdgConfigHome, "nats", "context")
+	assert.Contains(t, expectedContextFile, expectedContextDir, "Context file should be in XDG_CONFIG_HOME/nats/context, got: %s", expectedContextFile)
+
+	tmpHomeNatsDir := filepath.Join(tmpHomeDir, ".config", "nats", "context")
+	_, err := os.Stat(tmpHomeNatsDir)
+	assert.True(t, os.IsNotExist(err), "Files should not be created in HOME/.config/nats/context when XDG_CONFIG_HOME is set: %s", tmpHomeNatsDir)
+}
+
+func afterFuncDeleteFiles(ctx *core.AfterFuncCtx) error {
+	if ctx.Meta["deleteFiles"] == nil {
+		return nil
+	}
+	filesToDelete := ctx.Meta["deleteFiles"].([]string)
+	for _, file := range filesToDelete {
+		if err := os.Remove(file); err != nil {
+			return err
+		}
+	}
+
+	return nil
+}
+
 func Test_CreateContextWithXDGConfigHome(t *testing.T) {
 	xdgConfigHomeDir := t.TempDir()
 
@@ -163,68 +175,11 @@ func Test_CreateContextWithXDGConfigHome(t *testing.T) {
 					Replacement: "Select context using `nats context select context-placeholder`",
 				},
 			),
-			func(t *testing.T, ctx *core.CheckFuncCtx) {
-				t.Helper()
-				result, isSuccessResult := ctx.Result.(*core.SuccessResult)
-				assert.True(
-					t,
-					isSuccessResult,
-					"Expected result to be of type *core.SuccessResult, got %s",
-					reflect.TypeOf(result).String(),
-				)
-				assert.NotNil(t, result)
-
-				xdgConfigHome := ctx.OverrideEnv["XDG_CONFIG_HOME"]
-				tmpHomeDir := ctx.OverrideEnv["HOME"]
-
-				expectedContextFile := result.Resource
-				assert.True(
-					t,
-					mnq.FileExists(expectedContextFile),
-					"Expected context file not found: %s",
-					expectedContextFile,
-				)
-
-				expectedContextDir := filepath.Join(xdgConfigHome, "nats", "context")
-				assert.Contains(
-					t,
-					expectedContextFile,
-					expectedContextDir,
-					"Context file should be in XDG_CONFIG_HOME/nats/context, got: %s",
-					expectedContextFile,
-				)
-
-				tmpHomeNatsDir := filepath.Join(tmpHomeDir, ".config", "nats", "context")
-				tmpHomeNatsDirExists := false
-				if _, err := os.Stat(tmpHomeNatsDir); err == nil {
-					tmpHomeNatsDirExists = true
-				}
-				assert.False(
-					t,
-					tmpHomeNatsDirExists,
-					"Files should not be created in HOME/.config/nats/context when XDG_CONFIG_HOME is set: %s",
-					tmpHomeNatsDir,
-				)
-
-				ctx.Meta["deleteFiles"] = []string{expectedContextFile}
-			},
+			checkContextFileInXDGConfigHome,
 		),
 		AfterFunc: core.AfterFuncCombine(
 			deleteNATSAccount("NATS"),
-			func(ctx *core.AfterFuncCtx) error {
-				if ctx.Meta["deleteFiles"] == nil {
-					return nil
-				}
-				filesToDelete := ctx.Meta["deleteFiles"].([]string)
-				for _, file := range filesToDelete {
-					err := os.Remove(file)
-					if err != nil {
-						t.Errorf("Failed to delete the file : %s", err)
-					}
-				}
-
-				return nil
-			},
+			afterFuncDeleteFiles,
 		),
 	}))
 }