Skip to content

Problems with ops.equals #6

@ghost

Description

I have been encountering various problems with ops.equals when running tests for my own ndarray modules.

Different lengths seem to play a role. I wrote the following test and it fails:

var x2 = ndarray(new Float32Array([0]));
var y2 = ndarray(new Float32Array([0, 1]));
t.assert(!ops.equals(x2, y2))

Maybe this is outside the intended use case and you only intended that ndarrays with the same length and same underlying buffer format get compared. Nevertheless, having more robust falsiness behavior would make it easier to instrument and test modules.

I think there are other things. I will update this issue as I find them. I will also try to fix them.

UPDATE:
I am just going to implement my own equals method, since that would be faster/easier for me.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions