test suite: Generalize xspec completion install check

Extract from acroread, use for kdvi, kpdf, and vi in addition to it.

Fixes #130

Author: scop

test/completion/acroread.exp

@@ -1,12 +1,3 @@
-set test "Completion via _filedir_xspec() should be installed"
-set cmd "complete -p acroread"
-send "$cmd\r"
-
-set expected "^$cmd\r\ncomplete -F _filedir_xspec acroread\r\n/@$"
-expect {
-    -re $expected  { pass "$test" }
-    -re /@ { fail "$test at prompt" }
-}; # expect
-
+assert_xspec_completion_installed acroread
 
 source "$::srcdir/lib/completions/acroread.exp"

test/completion/kdvi.exp

@@ -1 +1,3 @@
-assert_source_completions kdvi
+assert_xspec_completion_installed kdvi
+
+source "$::srcdir/lib/completions/kdvi.exp"

test/completion/kpdf.exp

@@ -1 +1,3 @@
-assert_source_completions kpdf
+assert_xspec_completion_installed kpdf
+
+source "$::srcdir/lib/completions/kpdf.exp"

test/completion/vi.exp

@@ -1 +1,3 @@
-assert_source_completions vi
+assert_xspec_completion_installed vi
+
+source "$::srcdir/lib/completions/vi.exp"

test/lib/library.exp

@@ -602,6 +602,21 @@ proc assert_source_completions {command {file ""}} {
 }
 
 
+# Assert that a _filedir_xspec completion is installed for specified command
+# @param string $command  Command to check completion installation for.
+proc assert_xspec_completion_installed {command} {
+    set test "Completion via _filedir_xspec() should be installed"
+    set cmd "complete -p $command"
+    send "$cmd\r"
+
+    set expected "^$cmd\r\ncomplete -F _filedir_xspec $command\r\n/@$"
+    expect {
+        -re $expected { pass "$test" }
+        -re /@ { fail "$test at prompt" }
+    }
+}
+
+
 # Sort list.
 # `exec sort' is used instead of `lsort' to achieve exactly the
 #  same sort order as in bash.